From: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [PATCH i-g-t] tests/perf: dramatically loosen expectations on oa-exponents
Date: Mon, 30 Mar 2020 15:48:34 +0300 [thread overview]
Message-ID: <20200330124834.43038-1-lionel.g.landwerlin@intel.com> (raw)
This test really quite flaky because it expects HW to emit reports
following pretty much exactly the specified timer. And there are lots
of reasons the HW might not be able to meet the timer deadline. The
design is such that it's expected to not always meet the timer.
We just want to verify that the HW was configured properly, so loosen
the checks to half the reports (of 30) meeting the timer deadline.
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
---
tests/perf.c | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/tests/perf.c b/tests/perf.c
index 442d89fb..023829fc 100644
--- a/tests/perf.c
+++ b/tests/perf.c
@@ -1742,8 +1742,14 @@ test_oa_exponents(void)
igt_debug("matches=%u/%u\n", matches, n_timer_reports - 1);
- /* Allow for a couple of errors. */
- igt_assert_lte(n_timer_reports - 3, matches);
+ /*
+ * Expect half the reports to match the timing
+ * expectation. The results are quite erratic because
+ * the condition under which the HW reaches
+ * expectations depends on memory controller pressure
+ * etc...
+ */
+ igt_assert_lte(n_timer_reports / 2, matches);
}
load_helper_stop();
--
2.26.0
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next reply other threads:[~2020-03-30 12:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-30 12:48 Lionel Landwerlin [this message]
2020-03-30 13:29 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/perf: dramatically loosen expectations on oa-exponents Patchwork
2020-03-30 13:54 ` [igt-dev] [PATCH i-g-t] " Chris Wilson
2020-03-30 14:39 ` Lionel Landwerlin
2020-03-31 3:11 ` [igt-dev] ✗ Fi.CI.IGT: failure for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200330124834.43038-1-lionel.g.landwerlin@intel.com \
--to=lionel.g.landwerlin@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox