public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [PATCH i-g-t 2/4] lib/kms: Reprobe connector state after disabling modest
Date: Tue, 31 Mar 2020 15:38:55 +0300	[thread overview]
Message-ID: <20200331123857.1212432-3-arkadiusz.hiler@intel.com> (raw)
In-Reply-To: <20200331123857.1212432-1-arkadiusz.hiler@intel.com>

With TypeC we don't always get hotplug events for a connector until the
mode is disabled.

Cc: Imre Deak <imre.deak@intel.com>
Issue: https://gitlab.freedesktop.org/drm/intel/issues/323
Signed-off-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
---
 lib/igt_kms.c | 27 +++++++++++++++++++--------
 1 file changed, 19 insertions(+), 8 deletions(-)

diff --git a/lib/igt_kms.c b/lib/igt_kms.c
index 796da1fb..b461818a 100644
--- a/lib/igt_kms.c
+++ b/lib/igt_kms.c
@@ -2040,7 +2040,6 @@ void igt_display_require(igt_display_t *display, int drm_fd)
 
 	for (i = 0; i < display->n_outputs; i++) {
 		igt_output_t *output = &display->outputs[i];
-		drmModeConnector *connector;
 
 		/*
 		 * We don't assign each output a pipe unless
@@ -2051,13 +2050,6 @@ void igt_display_require(igt_display_t *display, int drm_fd)
 		output->display = display;
 
 		igt_output_refresh(output);
-
-		connector = output->config.connector;
-		if (connector && (!connector->count_modes ||
-		    connector->connection == DRM_MODE_UNKNOWNCONNECTION)) {
-			output->force_reprobe = true;
-			igt_output_refresh(output);
-		}
 	}
 
 	drmModeFreePlaneResources(plane_resources);
@@ -2070,6 +2062,25 @@ void igt_display_require(igt_display_t *display, int drm_fd)
 	igt_display_commit2(display,
 			    display->is_atomic ? COMMIT_ATOMIC : COMMIT_LEGACY);
 
+	/*
+	 * Let's reprobe all connectors to make sure we have up to date stete.
+	 * Some connectors may require disabling modeset to be detected
+	 * correctly.
+	 */
+	for (i = 0; i < display->n_outputs; i++) {
+		igt_output_t *output = &display->outputs[i];
+		drmModeConnector *connector;
+
+		igt_output_refresh(output);
+
+		connector = output->config.connector;
+		if (connector && (!connector->count_modes ||
+		    connector->connection == DRM_MODE_UNKNOWNCONNECTION)) {
+			output->force_reprobe = true;
+			igt_output_refresh(output);
+		}
+	}
+
 out:
 	LOG_UNINDENT(display);
 
-- 
2.24.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

  parent reply	other threads:[~2020-03-31 12:42 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-31 12:38 [igt-dev] [PATCH i-g-t 0/4] Chamelium and TypeC Arkadiusz Hiler
2020-03-31 12:38 ` [igt-dev] [PATCH i-g-t 1/4] lib/kms: Commit reasonable defaults on display init Arkadiusz Hiler
2020-03-31 12:38 ` Arkadiusz Hiler [this message]
2020-04-02 14:53   ` [igt-dev] [PATCH i-g-t 2/4] lib/kms: Reprobe connector state after disabling modest Imre Deak
2020-03-31 12:38 ` [igt-dev] [PATCH i-g-t 3/4] tests/kms_chamelium: Issue disabling modeset when resetting state Arkadiusz Hiler
2020-04-02  3:28   ` Kunal Joshi
2020-03-31 12:38 ` [igt-dev] [PATCH i-g-t 4/4] tests/kms_chamelium: Test HPD for different mode handling scenarios Arkadiusz Hiler
2020-04-01 16:29   ` [igt-dev] [PATCH i-g-t v2 " Arkadiusz Hiler
2020-04-02  2:25     ` Kunal Joshi
2020-04-02  9:56       ` Arkadiusz Hiler
2020-04-01  2:23 ` [igt-dev] ✓ Fi.CI.BAT: success for Chamelium and TypeC Patchwork
2020-04-01 17:04 ` [igt-dev] ✓ Fi.CI.BAT: success for Chamelium and TypeC (rev2) Patchwork
2020-04-01 18:17 ` [igt-dev] ✗ Fi.CI.IGT: failure for Chamelium and TypeC Patchwork
2020-04-02 13:00 ` [igt-dev] ✗ Fi.CI.IGT: failure for Chamelium and TypeC (rev2) Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200331123857.1212432-3-arkadiusz.hiler@intel.com \
    --to=arkadiusz.hiler@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox