From: Mika Kahola <mika.kahola@intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [PATCH i-g-t] tests/kms_cursor_legacy: Wait for an extra vblank
Date: Thu, 2 Apr 2020 14:07:29 +0300 [thread overview]
Message-ID: <20200402110729.18305-1-mika.kahola@intel.com> (raw)
kms_cursor_legacy IGT subtest 2x-nonblocking-modeset-vs-cursor-atomic
is failing due to busyness while trying to do atomic commit. In case,
we are busy, let's just wait one extra vblank before continuing the
test.
References: https://gitlab.freedesktop.org/drm/intel/issues/1062
Signed-off-by: Mika Kahola <mika.kahola@intel.com>
---
tests/kms_cursor_legacy.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/kms_cursor_legacy.c b/tests/kms_cursor_legacy.c
index d5f95b8d..13aadcce 100644
--- a/tests/kms_cursor_legacy.c
+++ b/tests/kms_cursor_legacy.c
@@ -894,7 +894,6 @@ static void two_screens_flip_vs_cursor(igt_display_t *display, int nloops, bool
arg2[1].x = arg2[1].y = 192;
-
igt_display_commit2(display, display->is_atomic ? COMMIT_ATOMIC : COMMIT_LEGACY);
igt_fork(child, 2) {
@@ -927,6 +926,7 @@ static void two_screens_flip_vs_cursor(igt_display_t *display, int nloops, bool
if (ret == -EBUSY) {
/* Force completion on both pipes, and generate event. */
+ igt_wait_for_vblank(display->drm_fd, pipe);
igt_display_commit_atomic(display, flags, NULL);
while (nloops--) {
--
2.20.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next reply other threads:[~2020-04-02 11:07 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-02 11:07 Mika Kahola [this message]
2020-04-02 16:40 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_cursor_legacy: Wait for an extra vblank Patchwork
2020-04-03 13:18 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2020-04-06 5:55 ` Kahola, Mika
2020-04-06 16:06 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_cursor_legacy: Wait for an extra vblank (rev2) Patchwork
2020-04-06 21:28 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2020-04-09 11:28 ` [igt-dev] ✗ GitLab.Pipeline: warning for tests/kms_cursor_legacy: Wait for an extra vblank (rev3) Patchwork
2020-04-09 11:40 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
2020-04-10 5:30 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2020-04-15 8:58 ` [igt-dev] [PATCH i-g-t] tests/kms_cursor_legacy: Wait for an extra vblank Juha-Pekka Heikkila
2020-04-15 10:26 ` Kahola, Mika
2020-04-15 10:55 ` Juha-Pekka Heikkila
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200402110729.18305-1-mika.kahola@intel.com \
--to=mika.kahola@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox