From: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Kunal Joshi <kunal1.joshi@intel.com>
Subject: [igt-dev] [PATCH i-g-t 1/3] test/kms_chamelium: Start with disabling modeset
Date: Tue, 14 Apr 2020 11:14:45 +0300 [thread overview]
Message-ID: <20200414081447.1451675-1-arkadiusz.hiler@intel.com> (raw)
Doing disabling modeset from igt_display_require() is quite tricky, as
there are some tests that depend on the leftover mode set by fbcon in
order to work + PSR debugfs checks seem to behave a bit weird.
While those issues are being worked on let's do a disabling modeset
between igt_display_require() and chamelium_init() so port
auto-discovery works reliably on all configurations.
Issue: https://gitlab.freedesktop.org/drm/intel/issues/323
Cc: Kunal Joshi <kunal1.joshi@intel.com>
Signed-off-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
---
tests/kms_chamelium.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/tests/kms_chamelium.c b/tests/kms_chamelium.c
index e5cfa633..b7207ef9 100644
--- a/tests/kms_chamelium.c
+++ b/tests/kms_chamelium.c
@@ -2520,6 +2520,12 @@ igt_main
igt_display_require(&data.display, data.drm_fd);
igt_require(data.display.is_atomic);
+ /*
+ * XXX: disabling modeset, can be removed when
+ * igt_display_require will start doing this for us
+ */
+ igt_display_commit2(&data.display, COMMIT_ATOMIC);
+
/* we need to initalize chamelium after igt_display_require */
data.chamelium = chamelium_init(data.drm_fd);
igt_require(data.chamelium);
--
2.24.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next reply other threads:[~2020-04-14 8:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-14 8:14 Arkadiusz Hiler [this message]
2020-04-14 1:30 ` [igt-dev] [PATCH i-g-t 1/3] test/kms_chamelium: Start with disabling modeset Kunal Joshi
2020-04-14 8:14 ` [igt-dev] [PATCH i-g-t 2/3] tests/kms_chamelium: Issue disabling modeset when resetting state Arkadiusz Hiler
2020-04-14 8:14 ` [igt-dev] [PATCH i-g-t 3/3] tests/kms_chamelium: Test HPD for different mode handling scenarios Arkadiusz Hiler
2020-04-14 13:27 ` [igt-dev] ✗ Fi.CI.BAT: failure for series starting with [i-g-t,1/3] test/kms_chamelium: Start with disabling modeset Patchwork
2020-04-14 13:31 ` Arkadiusz Hiler
2020-04-14 15:23 ` Vudum, Lakshminarayana
2020-04-14 14:14 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
2020-04-15 9:10 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200414081447.1451675-1-arkadiusz.hiler@intel.com \
--to=arkadiusz.hiler@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=kunal1.joshi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox