From: Kunal Joshi <kunal1.joshi@intel.com>
To: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_chamelium Capture on type-c
Date: Thu, 16 Apr 2020 09:56:09 +0530 [thread overview]
Message-ID: <20200416042609.GB22861@intel.com> (raw)
In-Reply-To: <20200416104149.iptyqjw4r6rq5jak@ahiler-desk1.fi.intel.com>
On 2020-04-16 at 13:41:49 +0300, Arkadiusz Hiler wrote:
> Handling of *connector is broken here and in the other chunk:
>
> 1. you get connector first and then use it to start iteration
>
> 2. you refresh the connector each iteration after you plug leaking the
> old one
>
> 3. there are no guarantee that the amount of modes will stay the same -
> link training and mode pruning may kick in
>
> 4. you are preparing output two times in a row for the first iteration
>
> You need to re-work the flow here and make sure that at least the number
> of modes stays constant.
>
> --
> Cheers,
> Arek
Thanks for the evaluation arek.
Will come over this things in the next version :).
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2020-04-16 11:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-16 3:21 [igt-dev] [PATCH i-g-t] tests/kms_chamelium Capture on type-c Kunal Joshi
2020-04-16 10:41 ` Arkadiusz Hiler
2020-04-16 4:26 ` Kunal Joshi [this message]
2020-04-16 11:30 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2020-04-17 10:38 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
-- strict thread matches above, loose matches on Subject: below --
2020-04-15 22:26 [igt-dev] [PATCH i-g-t] tests/kms_chamelium: " Kunal Joshi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200416042609.GB22861@intel.com \
--to=kunal1.joshi@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox