Re: [igt-dev] [PATCH i-g-t v5 4/5] tests/i915_pm_lpsp: screens-disabled subtest use igt_wait

[Anshuman Gupta <anshuman.gupta@intel.com>]

On 2020-04-17 at 19:57:47 +0530, Manna, Animesh wrote:
> 
> On 09-04-2020 11:09, Anshuman Gupta wrote:
> >When all screens are disabled, it takes some time to release
> >eDP/DP AUX IO power domain ref count. Also, delayed audio codec
> >disabling takes time to release AUDIO power domain ref-count,
> >using igt_wait to check lpsp after disabling all screens.
> >
> >Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com>
> >---
> >  tests/i915/i915_pm_lpsp.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> >diff --git a/tests/i915/i915_pm_lpsp.c b/tests/i915/i915_pm_lpsp.c
> >index 7be23e6c..e05d3791 100644
> >--- a/tests/i915/i915_pm_lpsp.c
> >+++ b/tests/i915/i915_pm_lpsp.c
> >@@ -79,7 +79,8 @@ static void screens_disabled_subtest(data_t *data)
> >  	}
> >  	igt_require_f(valid_output, "No connected output found\n");
> >-	igt_assert_f(lpsp_is_enabled(data), "lpsp is not enabled\n%s:\n%s\n",
> >+	igt_assert_f(igt_wait(lpsp_is_enabled(data), 1000, 100),
> 
> Better to add code-comment here how the above time is calculated. Is it based on observation or captured anywhere?
Thaks for review i will add a code comment here.
thanks,
Anshuman Gupta.
> 
> Regards,
> Animesh
> 
> >+		     "lpsp is not enabled\n%s:\n%s\n",
> >  		     PWR_DOMAIN_INFO, data->pwr_dmn_info =
> >  		     igt_sysfs_get(data->debugfs_fd, PWR_DOMAIN_INFO));
> >  }
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev