From: Lyude <lyude@redhat.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [PATCH i-g-t v2 1/5] lib/igt_core: Fix igt_assert_fd() documentation
Date: Fri, 17 Apr 2020 15:49:27 -0400 [thread overview]
Message-ID: <20200417194931.39774-2-lyude@redhat.com> (raw)
In-Reply-To: <20200417194931.39774-1-lyude@redhat.com>
From: Lyude Paul <lyude@redhat.com>
As Petri Latvala pointed out, some of the documentation in this macro is
mistakenly copied from the other igt_assert*() macros. Let's fix that.
Signed-off-by: Lyude Paul <lyude@redhat.com>
---
lib/igt_core.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/igt_core.h b/lib/igt_core.h
index b97fa2fa..3f69b072 100644
--- a/lib/igt_core.h
+++ b/lib/igt_core.h
@@ -966,8 +966,8 @@ void igt_describe_f(const char *fmt, ...);
*
* Fails (sub-) test if the given file descriptor is invalid.
*
- * Like igt_assert(), but displays the values being compared on failure instead
- * of simply printing the stringified expression.
+ * Like igt_assert(), but displays the stringified identifier that was supposed
+ * to contain a valid fd on failure.
*/
#define igt_assert_fd(fd) \
igt_assert_f(fd >= 0, "file descriptor " #fd " failed\n");
--
2.25.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2020-04-17 19:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-17 19:49 [igt-dev] [PATCH i-g-t v2 0/5] Add nouveau-crc tests Lyude
2020-04-17 19:49 ` Lyude [this message]
2020-04-17 19:49 ` [igt-dev] [PATCH i-g-t v2 2/5] lib/igt_core: Add igt_require_fd() Lyude
2020-04-17 19:49 ` [igt-dev] [PATCH i-g-t v2 3/5] lib/igt_debugfs: Add igt_debugfs_pipe_dir() Lyude
2020-04-17 19:49 ` [igt-dev] [PATCH i-g-t v2 4/5] lib/igt_kms: Hook up connector dithering prop Lyude
2020-04-17 19:49 ` [igt-dev] [PATCH i-g-t v2 5/5] tests: Add nouveau-crc tests Lyude
2020-04-17 20:10 ` [igt-dev] ✗ GitLab.Pipeline: warning for Add nouveau-crc tests (rev2) Patchwork
2020-04-17 20:28 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
2020-04-19 8:19 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200417194931.39774-2-lyude@redhat.com \
--to=lyude@redhat.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox