Re: [igt-dev] [Intel-gfx] [PATCH v7 i-g-t 4/4] kms_writeback: Add writeback-check-output

[Rodrigo Siqueira <rodrigosiqueiramelo@gmail.com>]

[-- Attachment #1.1: Type: text/plain, Size: 2265 bytes --]

On 04/15, Maxime Ripard wrote:
> Hi!
> 
> On Mon, Oct 21, 2019 at 10:00:39PM -0300, Brian Starkey wrote:
> > Add a test which makes commits using the writeback connector, and
> > checks the output buffer hash to make sure it is/isn't written as
> > appropriate.
> >
> > V6: Simon Ser
> >  - Add igt documentation with igt_describe
> >  - Replace int ret by unsigned int fd_id when calling igt_create_fb
> >  - Add a descriptive error message if sync_fence_wait fail
> >  - Replace color_idx variable by i
> >  - Use in_fb instead of out_fb for getting the expected CRC
> >  - Drop unnecessary parentheses
> >  - Replace igt_fb_mod_to_tiling to DRM_FORMAT_MOD_LINEAR
> >
> > Signed-off-by: Brian Starkey <brian.starkey@arm.com>
> > [rebased and updated the patch to address feedback]
> > Signed-off-by: Rodrigo Siqueira <rodrigosiqueiramelo@gmail.com>
> > ---
> >  tests/kms_writeback.c | 123 ++++++++++++++++++++++++++++++++++++++++++
> >  1 file changed, 123 insertions(+)
> >
> > diff --git a/tests/kms_writeback.c b/tests/kms_writeback.c
> > index a373ec4d..068595b9 100644
> > --- a/tests/kms_writeback.c
> > +++ b/tests/kms_writeback.c
> > @@ -30,6 +30,7 @@
> >  #include "igt.h"
> >  #include "igt_core.h"
> >  #include "igt_fb.h"
> > +#include "sw_sync.h"
> >
> >  IGT_TEST_DESCRIPTION("Exercise writeback feature.");
> >
> > @@ -196,6 +197,115 @@ static void writeback_test_fb(igt_output_t *output, igt_fb_t *valid_fb, igt_fb_t
> >  	igt_assert(ret == -EINVAL);
> >  }
> >
> > +static void fill_fb(igt_fb_t *fb, double color[3])
> > +{
> > +	cairo_t *cr = igt_get_cairo_ctx(fb->fd, fb);
> > +	igt_assert(cr);
> > +
> > +	igt_paint_color(cr, 0, 0, fb->width, fb->height,
> > +			color[0], color[1], color[2]);
> > +}
> > +
> 
> On which platform did you test this? On Arm (but I would assume
> anything !i915), this will fire up an assert.
> 
> I've replaced this with a igt_fb_map_buffer/memset, and it works as
> expected.

Hi,

Could you share your fix for this issue? Since you already have a
solution that you know that works on ARM, I can just use it for avoiding
an unnecessary round of review in the next version.

Thanks
 
> Maxime



-- 
Rodrigo Siqueira
https://siqueira.tech

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 154 bytes --]

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev