From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id 777AE6E356 for ; Wed, 22 Apr 2020 08:02:29 +0000 (UTC) Date: Wed, 22 Apr 2020 11:02:27 +0300 From: Petri Latvala Message-ID: <20200422080227.GA9497@platvala-desk.ger.corp.intel.com> References: <20200421161725.12249-1-juhapekka.heikkila@gmail.com> <20200421161725.12249-2-juhapekka.heikkila@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200421161725.12249-2-juhapekka.heikkila@gmail.com> Subject: Re: [igt-dev] [PATCH i-g-t 1/8] lib/params: add igt_params.c for module parameter access List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Juha-Pekka Heikkila Cc: igt-dev@lists.freedesktop.org, Jani Nikula List-ID: On Tue, Apr 21, 2020 at 07:17:18PM +0300, Juha-Pekka Heikkila wrote: > From: Jani Nikula > > We have generic helpers for sysfs access in igt_sysfs.c, but we also > have a number of module parameter access specific helpers scattered here > and there. Start gathering the latter into a file of its own. > > For i915, the long-term goal is to migrate from module parameters to > device specific debugfs parameters. With all igt module param access > centralized in one place, we can make the transition much easier. > > Signed-off-by: Jani Nikula > Signed-off-by: Juha-Pekka Heikkila This patch is just moving code around without functional changes, correct? > diff --git a/lib/meson.build b/lib/meson.build > index e2060430..c9af0403 100644 > --- a/lib/meson.build > +++ b/lib/meson.build > @@ -17,6 +17,7 @@ lib_sources = [ > 'igt_halffloat.c', > 'igt_matrix.c', > 'igt_perf.c', > + 'igt_params.c', > 'igt_primes.c', > 'igt_rand.c', > 'igt_rapl.c', Alphabetical ordering is off-by-one here. -- Petri Latvala _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev