Re: [igt-dev] [PATCH i-g-t 5/8] igt/params: add generic saving module parameter set

Juha-Pekka Heikkila
2020-04-28T18:43:38Z

On 28.4.2020 15.40, Petri Latvala wrote:
> On Tue, Apr 21, 2020 at 07:17:22PM +0300, Juha-Pekka Heikkila wrote:
>> From: Jani Nikula <jani.nikula@intel.com>
>>
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>> Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
>> ---
>> lib/igt_params.c | 56 ++++++++++++++++++++++++++++++++++++++++--------
>> lib/igt_params.h | 3 +++
>> 2 files changed, 50 insertions(+), 9 deletions(-)
>>
>> diff --git a/lib/igt_params.c b/lib/igt_params.c
>> index fe4b1df3..8de47b02 100644
>> --- a/lib/igt_params.c
>> +++ b/lib/igt_params.c
>> @@ -153,6 +153,29 @@ int igt_params_open(int device)
>> return __igt_params_open(device, NULL);
>> }
>>
>> +__attribute__((format(printf, 3, 0)))
>> +static bool __igt_params_set(int device, const char *parameter,
>> + const char *fmt, va_list ap, bool save)
>> +{
>> + char *path = NULL;
>> + int dir;
>> + int ret;
>> +
>> + dir = __igt_params_open(device, save ? &path : NULL);
>> + if (dir < 0)
>> + return false;
>> +
>> + if (save)
>> + igt_params_save(dir, path, parameter);
>> +
>> + ret = igt_sysfs_vprintf(dir, parameter, fmt, ap);
>> +
>> + close(dir);
>> + free(path);
>> +
>> + return ret > 0;
>> +}
>> +
>> /**
>> * igt_params_set:
>> * @device: fd of the device
>> @@ -164,20 +187,35 @@ int igt_params_open(int device)
>> bool igt_params_set(int device, const char *parameter, const char *fmt, ...)
>> {
>> va_list ap;
>> - int dir;
>> - int ret;
>> -
>> - dir = igt_params_open(device);
>> - if (dir < 0)
>> - return false;
>> + bool ret;
>>
>> va_start(ap, fmt);
>> - ret = igt_sysfs_vprintf(dir, parameter, fmt, ap);
>> + ret = __igt_params_set(device, parameter, fmt, ap, false);
>> va_end(ap);
>>
>> - close(dir);
>> + return ret;
>> +}
>>
>> - return ret > 0;
>> +/**
>> + * igt_params_set_save:
>> + * @device: fd of the device (or -1 to default to Intel)
>
>
> Default to Intel? Which Intel? Where is this defaulting implemented?

Yea, that comment will need some improvements. Wording smell bit like
it's coming from legacy times.