From: Janusz Krzysztofik <janusz.krzysztofik@linux.intel.com>
To: igt-dev@lists.freedesktop.org
Cc: intel-gfx@ists.freedesktop.org, Chris Wilson <chris@chris-wilson.co.uk>
Subject: [igt-dev] [PATCH i-g-t] tests/gem_exec_nop: "headless" requires submicrosecond precision
Date: Tue, 12 May 2020 12:24:47 +0200 [thread overview]
Message-ID: <20200512102447.9249-1-janusz.krzysztofik@linux.intel.com> (raw)
Commit 16f067ae42a6 ("i915/gem_exec_nop: Remove submission batching")
claimed to address the requirement of "headless" subtest for more
precise time measurement by keeping submission batching for it in
place. Unfortunately, that was not implemented and the requirement
is now not addressed.
Check how many requests can be submitted per second and skip the
subtest if less than 1000.
Signed-off-by: Janusz Krzysztofik <janusz.krzysztofik@linux.intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
---
tests/i915/gem_exec_nop.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tests/i915/gem_exec_nop.c b/tests/i915/gem_exec_nop.c
index 1c17d023d..2586db2d2 100644
--- a/tests/i915/gem_exec_nop.c
+++ b/tests/i915/gem_exec_nop.c
@@ -377,6 +377,8 @@ stable_nop_on_ring(int fd, uint32_t handle,
double time;
time = nop_on_ring(fd, handle, e, timeout, &count);
+ igt_skip_on_f(count < 1000 * timeout,
+ "submicrosecond precision of time measurement\n");
igt_stats_push_float(&s, time / count);
}
--
2.21.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next reply other threads:[~2020-05-12 10:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-12 10:24 Janusz Krzysztofik [this message]
2020-05-12 11:19 ` [igt-dev] ✗ Fi.CI.BAT: failure for tests/gem_exec_nop: "headless" requires submicrosecond precision Patchwork
2020-05-12 12:00 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
2020-05-12 13:27 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2020-05-12 17:19 ` [igt-dev] [PATCH i-g-t] i915/gem_exec_nop: Specify timeout in milliseconds Chris Wilson
2020-05-21 15:23 ` Janusz Krzysztofik
2020-05-12 18:10 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/gem_exec_nop: "headless" requires submicrosecond precision (rev2) Patchwork
2020-05-12 19:27 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2020-05-15 11:43 ` [igt-dev] ✗ GitLab.Pipeline: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200512102447.9249-1-janusz.krzysztofik@linux.intel.com \
--to=janusz.krzysztofik@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=igt-dev@lists.freedesktop.org \
--cc=intel-gfx@ists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox