From: "Zbigniew Kempczyński" <zbigniew.kempczynski@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Subject: [igt-dev] [PATCH i-g-t v2 4/7] lib/intel_batchbuffer: Introduce temporary igt_fillfunc_v2_t
Date: Fri, 15 May 2020 08:44:32 +0200 [thread overview]
Message-ID: <20200515064435.25926-5-zbigniew.kempczynski@intel.com> (raw)
In-Reply-To: <20200515064435.25926-1-zbigniew.kempczynski@intel.com>
gem_gpgpu_fill test is spread over different generations (gen >= 7)
so some transitional state is required until all gens will be
rewritten to new intel_bb code without libdrm dependency.
So, let's define new igt_fillfunc_v2_t to be new fill function.
Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
---
lib/intel_batchbuffer.c | 19 +++++++++++++++++++
lib/intel_batchbuffer.h | 8 ++++++++
2 files changed, 27 insertions(+)
diff --git a/lib/intel_batchbuffer.c b/lib/intel_batchbuffer.c
index 965e07dd..f3908a90 100644
--- a/lib/intel_batchbuffer.c
+++ b/lib/intel_batchbuffer.c
@@ -1152,6 +1152,25 @@ igt_fillfunc_t igt_get_gpgpu_fillfunc(int devid)
return fill;
}
+/**
+ * igt_get_gpgpu_fillfunc_v2:
+ * @devid: pci device id
+ *
+ * Returns:
+ *
+ * The platform-specific gpgpu fill function pointer for the device specified
+ * with @devid. Will return NULL when no gpgpu fill function is implemented.
+ */
+igt_fillfunc_v2_t igt_get_gpgpu_fillfunc_v2(int devid)
+{
+ igt_fillfunc_v2_t fill = NULL;
+
+ if (IS_GEN7(devid))
+ fill = gen7_gpgpu_fillfunc_v2;
+
+ return fill;
+}
+
/**
* igt_get_media_spinfunc:
* @devid: pci device id
diff --git a/lib/intel_batchbuffer.h b/lib/intel_batchbuffer.h
index c899ec9b..09d8d46b 100644
--- a/lib/intel_batchbuffer.h
+++ b/lib/intel_batchbuffer.h
@@ -391,8 +391,16 @@ typedef void (*igt_fillfunc_t)(struct intel_batchbuffer *batch,
unsigned width, unsigned height,
uint8_t color);
+struct intel_buf;
+typedef void (*igt_fillfunc_v2_t)(int i915,
+ struct intel_buf *buf,
+ unsigned x, unsigned y,
+ unsigned width, unsigned height,
+ uint8_t color);
+
igt_fillfunc_t igt_get_media_fillfunc(int devid);
igt_fillfunc_t igt_get_gpgpu_fillfunc(int devid);
+igt_fillfunc_v2_t igt_get_gpgpu_fillfunc_v2(int devid);
typedef void (*igt_vme_func_t)(struct intel_batchbuffer *batch,
const struct igt_buf *src,
--
2.26.0
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2020-05-15 6:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-15 6:44 [igt-dev] [PATCH i-g-t v2 0/7] Make gpgpu fill tests libdrm independent Zbigniew Kempczyński
2020-05-15 6:44 ` [igt-dev] [PATCH i-g-t v2 1/7] lib/intel_bufops: Add bufops reference and relaxate stride requirement Zbigniew Kempczyński
2020-05-15 6:44 ` [igt-dev] [PATCH i-g-t v2 2/7] lib/rendercopy_bufmgr: Pass alignment during buffer initialization Zbigniew Kempczyński
2020-05-15 6:44 ` [igt-dev] [PATCH i-g-t v2 3/7] lib/intel_batchbuffer: Introduce intel_bb Zbigniew Kempczyński
2020-05-15 6:44 ` Zbigniew Kempczyński [this message]
2020-05-15 6:44 ` [igt-dev] [PATCH i-g-t v2 5/7] lib/gpu_cmds: Add gpgpu pipeline functions based on intel_bb Zbigniew Kempczyński
2020-05-15 6:44 ` [igt-dev] [PATCH i-g-t v2 6/7] lib/gpgpu_fill: libdrm-free gpgpu pipeline creation for gen7 Zbigniew Kempczyński
2020-05-15 6:44 ` [igt-dev] [PATCH i-g-t v2 7/7] tests/gem_gpgpu_fill: Add gen7 version without libdrm dependency Zbigniew Kempczyński
2020-05-15 10:04 ` [igt-dev] ✓ Fi.CI.BAT: success for Make gpgpu fill tests libdrm independent (rev2) Patchwork
2020-05-15 11:44 ` [igt-dev] ✗ GitLab.Pipeline: warning " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200515064435.25926-5-zbigniew.kempczynski@intel.com \
--to=zbigniew.kempczynski@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox