From: Imre Deak <imre.deak@intel.com>
To: Anshuman Gupta <anshuman.gupta@intel.com>
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t] tests/i915_pm_rpm: Fix plane_subtest assertion
Date: Wed, 20 May 2020 09:56:42 +0300 [thread overview]
Message-ID: <20200520065642.GA26240@ideak-desk.fi.intel.com> (raw)
In-Reply-To: <20200520063541.24829-1-anshuman.gupta@intel.com>
On Wed, May 20, 2020 at 12:05:41PM +0530, Anshuman Gupta wrote:
> I have added igt_assert_lte() assertion on planes_tested
> unintentionally by mistake, while applying the patch and fixing
> the conflicts.
>
> Fixes: 32498f12ab04 ("tests/i915_pm_rpm: Fix the universal-plane cap setting in plane tests")
> Cc: Imre Deak <imre.deak@intel.com>
> Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com>
Reviewed-by: Imre Deak <imre.deak@intel.com>
> ---
> tests/i915/i915_pm_rpm.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/tests/i915/i915_pm_rpm.c b/tests/i915/i915_pm_rpm.c
> index 0a641640..6d46c320 100644
> --- a/tests/i915/i915_pm_rpm.c
> +++ b/tests/i915/i915_pm_rpm.c
> @@ -1786,7 +1786,7 @@ static void test_one_plane(bool dpms, uint32_t plane_id,
> /* This one also triggered WARNs on our driver at some point in time. */
> static void planes_subtest(bool universal, bool dpms)
> {
> - int i, planes_tested = 0, crtc_idx;
> + int i, crtc_idx;
> drmModePlaneResPtr planes;
>
> igt_require(default_mode_params);
> @@ -1817,7 +1817,6 @@ static void planes_subtest(bool universal, bool dpms)
>
> igt_assert_eq(drmSetClientCap(drm_fd, DRM_CLIENT_CAP_UNIVERSAL_PLANES,
> 1), 0);
> - igt_assert_lte(universal ? 3 : 1, planes_tested);
> }
>
> static void pm_test_tiling(void)
> --
> 2.26.0
>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2020-05-20 6:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-20 6:35 [igt-dev] [PATCH i-g-t] tests/i915_pm_rpm: Fix plane_subtest assertion Anshuman Gupta
2020-05-20 6:56 ` Imre Deak [this message]
2020-05-20 7:39 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2020-05-20 19:06 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200520065642.GA26240@ideak-desk.fi.intel.com \
--to=imre.deak@intel.com \
--cc=anshuman.gupta@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox