From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id B10A76E2B6 for ; Thu, 4 Jun 2020 08:39:25 +0000 (UTC) Date: Thu, 4 Jun 2020 11:39:22 +0300 From: Petri Latvala Message-ID: <20200604083922.GV9497@platvala-desk.ger.corp.intel.com> References: <20200603125414.1027845-1-arkadiusz.hiler@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200603125414.1027845-1-arkadiusz.hiler@intel.com> Subject: Re: [igt-dev] [PATCH i-g-t] lib/igt_core: Don't kill the world after a failed fork List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Arkadiusz Hiler Cc: igt-dev@lists.freedesktop.org, Michael Hebenstreit , Fei Yang List-ID: On Wed, Jun 03, 2020 at 03:54:14PM +0300, Arkadiusz Hiler wrote: > If we fail to fork (e.g. due to restrictive limits) -1 gets written as > PID of our child and we assert out. > > The cleanup that happens afterwards tries to kill all our children, > which ends up in kill(-1, SIGKILL) which is not good. > > This patch makes sure of two things: > * -1 doesn't get written down as our child > * when we are killing children we make sure that pid > 0 > > Reported-by: Fei Yang > Cc: Michael Hebenstreit > Cc: Petri Latvala > Signed-off-by: Arkadiusz Hiler Reviewed-by: Petri Latvala _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev