Re: [igt-dev] [PATCH] kms_cursor_legacy: Keep primary plane enabled for XRGB overlay fallback

["Ville Syrjälä" <ville.syrjala@linux.intel.com>]

On Fri, Jun 05, 2020 at 04:37:20PM +0200, Michel Dänzer wrote:
> From: Michel Dänzer <mdaenzer@redhat.com>
> 
> This allows the test to work on setups where the primary plane cannot
> be disabled while the CRTC is enabled.
> 
> It should make no difference for the output.
> 
> Signed-off-by: Michel Dänzer <mdaenzer@redhat.com>
> ---
>  tests/kms_cursor_legacy.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tests/kms_cursor_legacy.c b/tests/kms_cursor_legacy.c
> index 9306e54b..344442e8 100644
> --- a/tests/kms_cursor_legacy.c
> +++ b/tests/kms_cursor_legacy.c
> @@ -326,6 +326,7 @@ static void transition_nonblocking(igt_display_t *display, enum pipe pipe_id,
>  
>  		igt_assert(ret == -EINVAL);
>  
> +		igt_plane_set_fb(primary, prim_fb);
>  		igt_plane_set_fb(sprite, prim_fb);
>  	}
>  	igt_display_commit_atomic(display, DRM_MODE_ATOMIC_NONBLOCK | DRM_MODE_PAGE_FLIP_EVENT, display);

Mixes up the argb vs. xrgb with the primary vs. no primary thing a bit.
No idea why the test even wants an argb fb for the sprite tbh. Also not
sure there's an actual reason for toggling the primary on/off.

But meh. Patch seems OK to me.
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

PS.
I am wondering a bit how a driver that can't turn off the primary
will fare with some of the ther tests. IIRC quite a few might assume
you don't need an fb for the primary when using the atomic uapi...

> -- 
> 2.27.0
> 
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev

-- 
Ville Syrjälä
Intel
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev