From: Mohammed Khajapasha <mohammed.khajapasha@intel.com>
To: kishore.kunche@intel.com, petri.latvala@intel.com,
mohammed.khajapasha@freedesktop.org, arkadiusz.hiler@intel.com,
igt-dev@lists.freedesktop.org
Subject: [igt-dev] [[RFC] PATCH i-g-t 1/2] lib/drmtest: Don't write ffffffff to a numeric param
Date: Thu, 11 Jun 2020 00:41:45 +0530 [thread overview]
Message-ID: <20200610191146.10380-2-mohammed.khajapasha@intel.com> (raw)
In-Reply-To: <20200610191146.10380-1-mohammed.khajapasha@intel.com>
From: Petri Latvala <petri.latvala@intel.com>
__cancel_work_at_exit writes -1 to param "reset", with the intention
that it's "any available method". Hex values to numeric params should
be prefixed with 0x to be parsed as a number. Use the convention of %u
with -1 as is used elsewhere with the "reset" param.
Signed-off-by: Petri Latvala <petri.latvala@intel.com>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
---
lib/drmtest.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/drmtest.c b/lib/drmtest.c
index e4e710d4..c732d1dd 100644
--- a/lib/drmtest.c
+++ b/lib/drmtest.c
@@ -478,7 +478,7 @@ static void __cancel_work_at_exit(int fd)
{
igt_terminate_spins(); /* for older kernels */
- igt_params_set(fd, "reset", "%x", -1u /* any method */);
+ igt_params_set(fd, "reset", "%u", -1u /* any method */);
igt_drop_caches_set(fd,
/* cancel everything */
DROP_RESET_ACTIVE | DROP_RESET_SEQNO |
--
2.24.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2020-06-10 19:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-10 19:11 [igt-dev] [[RFC] PATCH i-g-t 0/2] lib/igt_kms: Add support for display with Mohammed Khajapasha
2020-06-10 19:11 ` Mohammed Khajapasha [this message]
2020-06-10 19:11 ` [igt-dev] [[RFC] PATCH i-g-t 2/2] lib/igt_kms: Add support for display with non-contiguous pipes Mohammed Khajapasha
2020-06-10 19:22 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200610191146.10380-2-mohammed.khajapasha@intel.com \
--to=mohammed.khajapasha@intel.com \
--cc=arkadiusz.hiler@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=kishore.kunche@intel.com \
--cc=mohammed.khajapasha@freedesktop.org \
--cc=petri.latvala@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox