Re: [igt-dev] [PATCH i-g-t 1/2] scripts/generate_clear_kernel: Improve usage instructions.

[Rodrigo Vivi <rodrigo.vivi@intel.com>]

On Thu, Jun 11, 2020 at 12:35:02PM +0300, Petri Latvala wrote:
> On Wed, Jun 10, 2020 at 08:44:34PM -0700, Rodrigo Vivi wrote:
> > Fix the script name and make the path to mesa i915_asm a bit
> > more clear
> > 
> > Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> 
> For the series:
> 
> Reviewed-by: Petri Latvala <petri.latvala@intel.com>


thanks, pushed

> 
> 
> 
> > ---
> >  scripts/generate_clear_kernel.sh | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/scripts/generate_clear_kernel.sh b/scripts/generate_clear_kernel.sh
> > index af628a86..90bbdf5d 100755
> > --- a/scripts/generate_clear_kernel.sh
> > +++ b/scripts/generate_clear_kernel.sh
> > @@ -26,7 +26,7 @@
> >  export ASSEMBLY_SOURCE=./lib/i915/shaders/clear_kernel
> >  
> >  function get_help {
> > -        echo "Usage:    asm_eu_kernel.sh [options]"
> > +        echo "Usage: ${0} [options]"
> >          echo "Note: hsw_clear_kernel.c/ivb_clear_kernel.c automatically generated by this script should never be modified - it would be imported to i915, to use as it is..."
> >          echo " "
> >          echo "Please make sure your Mesa tool is compiled with "-Dtools=intel" and "-Ddri-drivers=i965", and run this script from IGT source root directory"
> > @@ -37,7 +37,7 @@ function get_help {
> >          echo " -o=name_of_file          output file to store Mesa assembled c-literal for the device - If none specified, default file will be used - ivb/hsw-cb_assembled"
> >          echo " -m=mesa                  Path to Mesa i965_asm binary"
> >          echo " "
> > -        echo " Usage example: \"scripts/generate_clear_kernel.sh -g hsw -o hsw_clear_buffer.h -m /path/to/Mesa/i965_asm/binary\""
> > +        echo " Usage example: \"./scripts/generate_clear_kernel.sh -g hsw -o hsw_clear_buffer.h -m ~/mesa/build/src/intel/tools/i965_asm\""
> >  }
> >  
> >  function include_array # $1=array_name - update Mesa output with desired format
> > -- 
> > 2.24.1
> > 
> > _______________________________________________
> > igt-dev mailing list
> > igt-dev@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/igt-dev
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev