From: Janusz Krzysztofik <janusz.krzysztofik@linux.intel.com>
To: igt-dev@lists.freedesktop.org
Cc: intel-gfx@lists.freedesktop.org
Subject: [igt-dev] [RFC PATCH i-g-t v2 6/8] tests/core_hotunplug: Add 'GEM object' variant
Date: Mon, 22 Jun 2020 18:44:13 +0200 [thread overview]
Message-ID: <20200622164415.30352-7-janusz.krzysztofik@linux.intel.com> (raw)
In-Reply-To: <20200622164415.30352-1-janusz.krzysztofik@linux.intel.com>
GEM objects belonging to user file descriptors still open on device
hotunplug may exhibit still more driver issues. Add a subtest that
implements this scenario.
v2: rebase on upstream
Signed-off-by: Janusz Krzysztofik <janusz.krzysztofik@linux.intel.com>
---
tests/core_hotunplug.c | 30 ++++++++++++++++++++++++++++++
1 file changed, 30 insertions(+)
diff --git a/tests/core_hotunplug.c b/tests/core_hotunplug.c
index 18a963564..c30d98a69 100644
--- a/tests/core_hotunplug.c
+++ b/tests/core_hotunplug.c
@@ -356,6 +356,29 @@ static void vm_hotunplug_lateclose(void)
healthcheck();
}
+static void gem_hotunplug_lateclose(void)
+{
+ struct hotunplug priv;
+
+ prepare_for_rescan(&priv);
+
+ igt_require_gem(priv.fd.drm);
+
+ local_debug("creating a GEM user object");
+ igt_ignore_warn(gem_create(priv.fd.drm, 4096));
+
+ local_debug("hot unplugging the device");
+ device_unplug(priv.fd.sysfs_dev);
+
+ local_debug("late closing the removed device instance");
+ close(priv.fd.drm);
+
+ local_debug("recovering the device");
+ bus_rescan(priv.fd.sysfs_bus);
+
+ healthcheck();
+}
+
/* Main */
igt_main
@@ -435,4 +458,11 @@ igt_main
igt_fixture
igt_abort_on_f(failure, "%s\n", failure);
+
+ igt_describe("Check if a device with a still open GEM object can be cleanly unplugged, then released and recovered");
+ igt_subtest("gem-hotunplug-lateclose")
+ gem_hotunplug_lateclose();
+
+ igt_fixture
+ igt_abort_on_f(failure, "%s\n", failure);
}
--
2.21.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2020-06-22 16:44 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-22 16:44 [igt-dev] [RFC PATCH i-g-t v2 0/8] tests/core_hotunplug: New subtests and enhancements Janusz Krzysztofik
2020-06-22 16:44 ` [igt-dev] [RFC PATCH i-g-t v2 1/8] tests/core_hotunplug: Duplicate debug messages in dmesg Janusz Krzysztofik
2020-06-25 15:27 ` [Intel-gfx] " Michał Winiarski
2020-06-26 10:18 ` [igt-dev] " Janusz Krzysztofik
2020-07-08 12:49 ` Arkadiusz Hiler
2020-06-22 16:44 ` [igt-dev] [RFC PATCH i-g-t v2 2/8] tests/core_hotunplug: Use PCI device sysfs entry, not DRM Janusz Krzysztofik
2020-06-25 19:23 ` [Intel-gfx] " Michał Winiarski
2020-06-26 10:20 ` Janusz Krzysztofik
2020-06-22 16:44 ` [igt-dev] [RFC PATCH i-g-t v2 3/8] tests/core_hotunplug: Add unbind-unplug-rescan variant Janusz Krzysztofik
2020-06-25 19:32 ` Michał Winiarski
2020-06-22 16:44 ` [igt-dev] [RFC PATCH i-g-t v2 4/8] tests/core_hotunplug: Add 'lateclose before recover' variants Janusz Krzysztofik
2020-06-25 19:39 ` [igt-dev] [Intel-gfx] " Michał Winiarski
2020-06-22 16:44 ` [igt-dev] [RFC PATCH i-g-t v2 5/8] tests/core_hotunplug: Add 'GEM address space' variant Janusz Krzysztofik
2020-06-25 19:42 ` [Intel-gfx] " Michał Winiarski
2020-06-26 8:04 ` Janusz Krzysztofik
2020-06-22 16:44 ` Janusz Krzysztofik [this message]
2020-06-25 19:51 ` [igt-dev] [RFC PATCH i-g-t v2 6/8] tests/core_hotunplug: Add 'GEM object' variant Michał Winiarski
2020-06-26 8:26 ` Janusz Krzysztofik
2020-06-22 16:44 ` [igt-dev] [RFC PATCH i-g-t v2 7/8] tests/core_hotunplug: Add 'PRIME handle' variant Janusz Krzysztofik
2020-06-25 19:57 ` Michał Winiarski
2020-06-26 10:56 ` Janusz Krzysztofik
2020-06-22 16:44 ` [Intel-gfx] [RFC PATCH i-g-t v2 8/8] tests/core_hotunplug: Add 'GEM batch' variant Janusz Krzysztofik
2020-06-25 20:02 ` [igt-dev] " Michał Winiarski
2020-06-26 8:51 ` Janusz Krzysztofik
2020-06-22 18:09 ` [igt-dev] ✗ Fi.CI.IGT: failure for tests/core_hotunplug: New subtests and enhancements (rev2) Patchwork
2020-06-23 7:03 ` [igt-dev] ✗ GitLab.Pipeline: warning " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200622164415.30352-7-janusz.krzysztofik@linux.intel.com \
--to=janusz.krzysztofik@linux.intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox