From: Mohammed Khajapasha <mohammed.khajapasha@intel.com>
To: arkadiusz.hiler@intel.com, igt-dev@lists.freedesktop.org
Subject: [igt-dev] [PATCH i-g-t v3 5/7] lib/kms: Skip igt test cases for disabled display pipes
Date: Thu, 25 Jun 2020 11:53:16 +0530 [thread overview]
Message-ID: <20200625062318.26368-6-mohammed.khajapasha@intel.com> (raw)
In-Reply-To: <20200625062318.26368-1-mohammed.khajapasha@intel.com>
Skip igt test cases for disabled pipes.
Signed-off-by: Mohammed Khajapasha <mohammed.khajapasha@intel.com>
---
lib/igt_kms.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/lib/igt_kms.c b/lib/igt_kms.c
index 1b20c7e8..f2909ca5 100644
--- a/lib/igt_kms.c
+++ b/lib/igt_kms.c
@@ -2166,8 +2166,9 @@ void igt_display_require_output_on_pipe(igt_display_t *display, enum pipe pipe)
{
igt_output_t *output;
- igt_skip_on_f(pipe >= igt_display_get_n_pipes(display),
- "Pipe %s does not exist.\n", kmstest_pipe_name(pipe));
+ igt_skip_on_f(((pipe >= igt_display_get_n_pipes(display)) ||
+ !(display->pipes[pipe].enabled)),
+ "Pipe %s does not exist or not enabled.\n", kmstest_pipe_name(pipe));
for_each_valid_output_on_pipe(display, pipe, output)
return;
@@ -2522,7 +2523,8 @@ igt_output_t *igt_get_single_output_for_pipe(igt_display_t *display, enum pipe p
igt_output_t *chosen_outputs[display->n_pipes];
igt_assert(pipe != PIPE_NONE);
- igt_require(pipe < display->n_pipes);
+ igt_require((pipe < display->n_pipes) &&
+ display->pipes[pipe].enabled);
__igt_pipe_populate_outputs(display, chosen_outputs);
--
2.24.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2020-06-25 6:24 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-17 18:03 [igt-dev] [PATCH i-g-t 0/6] lib/igt_kms: Add support for display with Mohammed Khajapasha
2020-06-17 18:03 ` [igt-dev] [PATCH i-g-t 1/6] lib/igt_kms: Add support for display with non-contiguous pipes Mohammed Khajapasha
2020-06-17 18:06 ` Khajapasha, Mohammed
2020-06-18 8:33 ` Petri Latvala
2020-06-18 9:35 ` [igt-dev] [PATCH i-g-t] " Mohammed Khajapasha
2020-06-17 18:03 ` [igt-dev] [PATCH i-g-t 2/6] tests/kms_cursor_legacy: Read crtc id for enable pipes Mohammed Khajapasha
2020-06-17 18:03 ` [igt-dev] [PATCH i-g-t 3/6] tests/kms_lease: Get pipe from crtc " Mohammed Khajapasha
2020-06-17 18:03 ` [igt-dev] [PATCH i-g-t 4/6] tests/kms_lease: Read crtc id for a valid pipe Mohammed Khajapasha
2020-06-17 18:03 ` [igt-dev] [PATCH i-g-t 5/6] lib/kms: Skip igt test cases for disabled display pipes Mohammed Khajapasha
2020-06-17 18:03 ` [igt-dev] [PATCH i-g-t 6/6] tests/kms: Skip kms test cases for disabled pipes Mohammed Khajapasha
2020-06-17 18:36 ` [igt-dev] ✓ Fi.CI.BAT: success for lib/igt_kms: Add support for display with Patchwork
2020-06-17 19:36 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2020-06-18 10:56 ` [igt-dev] ✓ Fi.CI.BAT: success for lib/igt_kms: Add support for display with (rev2) Patchwork
2020-06-18 12:52 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2020-06-18 15:32 ` [igt-dev] ✗ GitLab.Pipeline: warning for lib/igt_kms: Add support for display with Patchwork
2020-06-18 15:32 ` [igt-dev] ✗ GitLab.Pipeline: warning for lib/igt_kms: Add support for display with (rev2) Patchwork
2020-06-25 6:23 ` [igt-dev] [PATCH i-g-t v3 0/7] lib/igt_kms: Add support for display with Mohammed Khajapasha
2020-06-25 6:23 ` [igt-dev] [PATCH i-g-t v3 1/7] lib/igt_kms: Add support for display with non-contiguous pipes Mohammed Khajapasha
2020-06-30 12:02 ` Arkadiusz Hiler
2020-07-01 7:04 ` Khajapasha, Mohammed
2020-07-01 7:51 ` Arkadiusz Hiler
2020-07-01 7:27 ` Khajapasha, Mohammed
2020-06-25 6:23 ` [igt-dev] [PATCH i-g-t v3 2/7] tests/kms_cursor_legacy: Read crtc id for enable pipes Mohammed Khajapasha
2020-06-30 12:27 ` Arkadiusz Hiler
2020-07-01 11:45 ` Khajapasha, Mohammed
2020-06-25 6:23 ` [igt-dev] [PATCH i-g-t v3 3/7] tests/kms_lease: Get pipe from crtc " Mohammed Khajapasha
2020-06-25 6:23 ` [igt-dev] [PATCH i-g-t v3 4/7] tests/kms_lease: Read crtc id for a valid pipe Mohammed Khajapasha
2020-06-25 6:23 ` Mohammed Khajapasha [this message]
2020-06-25 6:23 ` [igt-dev] [PATCH i-g-t v3 6/7] tests/kms: Skip kms test cases for disabled pipes Mohammed Khajapasha
2020-06-30 12:22 ` Arkadiusz Hiler
2020-06-25 6:23 ` [igt-dev] [PATCH i-g-t v3 7/7] tests/kms_atomic_transition: Set modeset for enable pipes only Mohammed Khajapasha
2020-06-25 6:35 ` [igt-dev] [PATCH i-g-t v3 0/7] lib/igt_kms: Add support for display with Mohammed Khajapasha
2020-06-25 6:35 ` [igt-dev] [PATCH i-g-t v3 1/7] lib/igt_kms: Add support for display with non-contiguous pipes Mohammed Khajapasha
2020-06-25 6:35 ` [igt-dev] [PATCH i-g-t v3 2/7] tests/kms_cursor_legacy: Read crtc id for enable pipes Mohammed Khajapasha
2020-06-25 6:35 ` [igt-dev] [PATCH i-g-t v3 3/7] tests/kms_lease: Get pipe from crtc " Mohammed Khajapasha
2020-06-25 6:35 ` [igt-dev] [PATCH i-g-t v3 4/7] tests/kms_lease: Read crtc id for a valid pipe Mohammed Khajapasha
2020-06-25 6:35 ` [igt-dev] [PATCH i-g-t v3 5/7] lib/kms: Skip igt test cases for disabled display pipes Mohammed Khajapasha
2020-06-25 6:35 ` [igt-dev] [PATCH i-g-t v3 6/7] tests/kms: Skip kms test cases for disabled pipes Mohammed Khajapasha
2020-06-25 6:35 ` [igt-dev] [PATCH i-g-t v3 7/7] tests/kms_atomic_transition: Set modeset for enable pipes only Mohammed Khajapasha
2020-06-25 8:57 ` [igt-dev] ✓ Fi.CI.BAT: success for lib/igt_kms: Add support for display with (rev2) Patchwork
2020-06-25 11:29 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200625062318.26368-6-mohammed.khajapasha@intel.com \
--to=mohammed.khajapasha@intel.com \
--cc=arkadiusz.hiler@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox