From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by gabe.freedesktop.org (Postfix) with ESMTPS id F134A89C37 for ; Tue, 30 Jun 2020 08:59:10 +0000 (UTC) Date: Tue, 30 Jun 2020 14:26:53 +0530 From: "Melkaveri, Arjun" Message-ID: <20200630085652.GA4322@arjun-NUC8i7BEH> References: <20200630064110.4585-1-sai.gowtham.ch@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200630064110.4585-1-sai.gowtham.ch@intel.com> Subject: Re: [igt-dev] [PATCH i-g-t] i915/gem_exec_create: Added test description for test case List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: sai.gowtham.ch@intel.com Cc: igt-dev@lists.freedesktop.org List-ID: On Tue, Jun 30, 2020 at 12:11:10PM +0530, sai.gowtham.ch@intel.com wrote: > From: sai gowtham > > Added test description for test and to all 3 subtests. > > Signed-off-by: sai gowtham > --- > tests/i915/gem_exec_create.c | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) > > diff --git a/tests/i915/gem_exec_create.c b/tests/i915/gem_exec_create.c > index ee7d4e5d..5236d477 100644 > --- a/tests/i915/gem_exec_create.c > +++ b/tests/i915/gem_exec_create.c > @@ -42,6 +42,10 @@ > #include "i915/gem.h" > #include "igt.h" > > +IGT_TEST_DESCRIPTION("\n This test runs an uninterrupted loop within the specified timeouts" > + " with different flags & ncpus combinations and checks if there are any" > + " missed interrupts reported from the driver."); > + > #define ENGINE_FLAGS (I915_EXEC_RING_MASK | I915_EXEC_BSD_MASK) > > static double elapsed(const struct timespec *start, const struct timespec *end) > @@ -133,12 +137,16 @@ igt_main > > igt_fork_hang_detector(device); > } > - > + igt_describe("Runs single uninterrupted loop for 2s."); > igt_subtest("basic") > all(device, 0, 2, 1); > + > + igt_describe("Runs single uninterrupted loop for 20s."); Can you add more information here . What happens in Forked subtest > igt_subtest("forked") > all(device, 0, 20, ncpus); > > + igt_describe("Runs single uninterrupted loop with" > + " different flag combination for 20s."); Same as above , Need more description of subtest . What does LEAK here signify . git blame/log would give you moe information to update this . > igt_subtest("madvise") > all(device, LEAK, 20, 1); > > -- > 2.25.0 > _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev