From: Mika Kuoppala <mika.kuoppala@linux.intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Subject: [igt-dev] [PATCH i-g-t] lib: Fix interface descriptor fills
Date: Fri, 3 Jul 2020 14:23:33 +0300 [thread overview]
Message-ID: <20200703112333.4237-1-mika.kuoppala@linux.intel.com> (raw)
For gen8+ we need to increment the pointer for interface
descriptor size amount. Otherwise the next indirect item
introduced will overwrite our descriptor.
Apparently this has not caused much havoc as interface
descs has been the last item.
Cc: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
---
lib/gpu_cmds.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/lib/gpu_cmds.c b/lib/gpu_cmds.c
index 417253a7..81156d25 100644
--- a/lib/gpu_cmds.c
+++ b/lib/gpu_cmds.c
@@ -363,6 +363,8 @@ gen8_fill_interface_descriptor(struct intel_bb *ibb,
idd->desc6.num_threads_in_tg = 1;
+ intel_bb_ptr_add(ibb, sizeof(*idd));
+
return offset;
}
@@ -399,6 +401,8 @@ gen11_fill_interface_descriptor(struct intel_bb *ibb,
idd->desc6.num_threads_in_tg = 1;
+ intel_bb_ptr_add(ibb, sizeof(*idd));
+
return offset;
}
--
2.17.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next reply other threads:[~2020-07-03 11:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-03 11:23 Mika Kuoppala [this message]
2020-07-03 11:35 ` [igt-dev] [PATCH i-g-t] lib: Fix interface descriptor fills Zbigniew Kempczyński
2020-07-03 12:21 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2020-07-03 14:11 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2020-07-03 14:50 ` Mika Kuoppala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200703112333.4237-1-mika.kuoppala@linux.intel.com \
--to=mika.kuoppala@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox