public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Petri Latvala <petri.latvala@intel.com>
To: Matt Atwood <matthew.s.atwood@intel.com>
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_scaling: set minimum height and width to 20
Date: Mon, 20 Jul 2020 12:11:11 +0300	[thread overview]
Message-ID: <20200720091111.GN20883@platvala-desk.ger.corp.intel.com> (raw)
In-Reply-To: <20200618152707.6855-1-matthew.s.atwood@intel.com>

On Thu, Jun 18, 2020 at 08:27:07AM -0700, Matt Atwood wrote:
> Depending on pixel format for gen11+ platforms minimum width can be as
> high as 20. Set width and height to 20. Remove is_planar_yuv_format, no
> longer used.
> 
> Signed-off-by: Matt Atwood <matthew.s.atwood@intel.com>

Reviewed-by: Petri Latvala <petri.latvala@intel.com>



> ---
>  tests/kms_plane_scaling.c | 17 +----------------
>  1 file changed, 1 insertion(+), 16 deletions(-)
> 
> diff --git a/tests/kms_plane_scaling.c b/tests/kms_plane_scaling.c
> index 19087286a..ecd2c2e30 100644
> --- a/tests/kms_plane_scaling.c
> +++ b/tests/kms_plane_scaling.c
> @@ -62,19 +62,6 @@ static int get_num_scalers(data_t* d, enum pipe pipe)
>  		return 1;
>  }
>  
> -static bool is_planar_yuv_format(uint32_t pixelformat)
> -{
> -	switch (pixelformat) {
> -	case DRM_FORMAT_NV12:
> -	case DRM_FORMAT_P010:
> -	case DRM_FORMAT_P012:
> -	case DRM_FORMAT_P016:
> -		return true;
> -	default:
> -		return false;
> -	}
> -}
> -
>  static void cleanup_fbs(data_t *data)
>  {
>  	int i;
> @@ -147,9 +134,7 @@ static void check_scaling_pipe_plane_rot(data_t *d, igt_plane_t *plane,
>  	mode = igt_output_get_mode(output);
>  
>  	/* create buffer in the range of  min and max source side limit.*/
> -	width = height = 8;
> -	if (is_i915_device(d->drm_fd) && is_planar_yuv_format(pixel_format))
> -		width = height = 16;
> +	width = height = 20;
>  	igt_create_color_fb(display->drm_fd, width, height,
>  		       pixel_format, tiling, 0.0, 1.0, 0.0, &d->fb[0]);
>  	igt_plane_set_fb(plane, &d->fb[0]);
> -- 
> 2.21.3
> 
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

      parent reply	other threads:[~2020-07-20  9:11 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-18 15:27 [igt-dev] [PATCH i-g-t] tests/kms_plane_scaling: set minimum height and width to 20 Matt Atwood
2020-06-18 15:32 ` [igt-dev] ✗ GitLab.Pipeline: warning for " Patchwork
2020-06-18 15:53 ` [igt-dev] ✗ Fi.CI.BAT: failure " Patchwork
2020-06-18 22:07   ` Atwood, Matthew S
2020-06-20 19:40     ` Vudum, Lakshminarayana
2020-06-21 12:22       ` Vudum, Lakshminarayana
2020-06-21 17:38         ` Saarinen, Jani
2020-06-21 12:18 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
2020-06-21 13:24 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2020-07-20  9:11 ` Petri Latvala [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200720091111.GN20883@platvala-desk.ger.corp.intel.com \
    --to=petri.latvala@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=matthew.s.atwood@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox