Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Zbigniew Kempczyński" <zbigniew.kempczynski@intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [PATCH i-g-t v10 14/17] lib/intel_batchbuffer: change alignment constraints on gen3
Date: Tue, 28 Jul 2020 11:35:44 +0200	[thread overview]
Message-ID: <20200728093547.23682-15-zbigniew.kempczynski@intel.com> (raw)
In-Reply-To: <20200728093547.23682-1-zbigniew.kempczynski@intel.com>

Gen3 requires bigger alignment on tiled buffers. Change to power
of two sized (starting from 1MB).

Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
---
 lib/intel_batchbuffer.c | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/lib/intel_batchbuffer.c b/lib/intel_batchbuffer.c
index 3ae369b7..cd5278b0 100644
--- a/lib/intel_batchbuffer.c
+++ b/lib/intel_batchbuffer.c
@@ -1578,6 +1578,16 @@ intel_bb_add_intel_buf(struct intel_bb *ibb, struct intel_buf *buf, bool write)
 		obj->alignment = 0x10000;
 	}
 
+	/* For gen3 ensure tiled buffers are aligned to power of two size */
+	if (ibb->gen == 3 && buf->tiling) {
+		uint64_t alignment = 1024 * 1024;
+
+		while (alignment < buf->surface[0].size)
+			alignment <<= 1;
+		obj->offset &= ~(alignment - 1);
+		obj->alignment = alignment;
+	}
+
 	/* Update address in intel_buf buffer */
 	buf->addr.offset = obj->offset;
 
-- 
2.26.0

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

  parent reply	other threads:[~2020-07-28  9:36 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-28  9:35 [igt-dev] [PATCH i-g-t v10 00/17] Remove libdrm in rendercopy Zbigniew Kempczyński
2020-07-28  9:35 ` [igt-dev] [PATCH i-g-t v10 01/17] lib/intel_bufops: add mapping on cpu / device Zbigniew Kempczyński
2020-07-28  9:35 ` [igt-dev] [PATCH i-g-t v10 02/17] lib/intel_batchbuffer: add new functions to support rendercopy Zbigniew Kempczyński
2020-07-28  9:35 ` [igt-dev] [PATCH i-g-t v10 03/17] tests/gem_caching|partial: adopt to batch flush function cleanup Zbigniew Kempczyński
2020-07-28  9:35 ` [igt-dev] [PATCH i-g-t v10 04/17] lib/rendercopy: remove libdrm dependency Zbigniew Kempczyński
2020-07-28  9:35 ` [igt-dev] [PATCH i-g-t v10 05/17] tests/api_intel_bb: add render tests Zbigniew Kempczyński
2020-07-28  9:35 ` [igt-dev] [PATCH i-g-t v10 06/17] lib/intel_batchbuffer: use canonical addresses for 48bit ppgtt Zbigniew Kempczyński
2020-07-28  9:35 ` [igt-dev] [PATCH i-g-t v10 07/17] lib/igt_draw: remove libdrm dependency Zbigniew Kempczyński
2020-07-28  9:35 ` [igt-dev] [PATCH i-g-t v10 08/17] lib/igt_fb: Removal of " Zbigniew Kempczyński
2020-07-28  9:35 ` [igt-dev] [PATCH i-g-t v10 09/17] tests/gem|kms: remove libdrm dependency (batch 1) Zbigniew Kempczyński
2020-07-28  9:35 ` [igt-dev] [PATCH i-g-t v10 10/17] tests/gem|kms: remove libdrm dependency (batch 2) Zbigniew Kempczyński
2020-07-28  9:35 ` [igt-dev] [PATCH i-g-t v10 11/17] tools/intel_residency: adopt intel_residency to use bufops Zbigniew Kempczyński
2020-07-28  9:35 ` [igt-dev] [PATCH i-g-t v10 12/17] tests/perf: remove libdrm dependency for rendercopy Zbigniew Kempczyński
2020-07-28 11:25   ` Lionel Landwerlin
2020-07-28  9:35 ` [igt-dev] [PATCH i-g-t v10 13/17] lib/intel_batchbuffer: dump bb to base64 Zbigniew Kempczyński
2020-07-28  9:35 ` Zbigniew Kempczyński [this message]
2020-07-28  9:35 ` [igt-dev] [PATCH i-g-t v10 15/17] tests/api_intel_bb: base64 dumping code Zbigniew Kempczyński
2020-07-28  9:35 ` [igt-dev] [PATCH i-g-t v10 16/17] api_intel_bb: temporary tests to check stride on gen3 Zbigniew Kempczyński
2020-07-28  9:35 ` [igt-dev] [PATCH i-g-t v10 17/17] HAX: run rendercopy tests Zbigniew Kempczyński
2020-07-28 10:49   ` Petri Latvala
2020-07-29 17:34     ` Zbigniew Kempczyński
2020-07-28 10:15 ` [igt-dev] ✗ Fi.CI.BAT: failure for Remove libdrm in rendercopy (rev10) Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200728093547.23682-15-zbigniew.kempczynski@intel.com \
    --to=zbigniew.kempczynski@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox