Re: [igt-dev] [PATCH i-g-t 0/5] tests: Add timeline semaphore tests

[daniel@ffwll.ch]

On Wed, Jul 08, 2020 at 04:20:10PM +0300, Lionel Landwerlin wrote:
> Just a rebase of the tests sent a while ago.
> 
> Cheers,
> 
> Chunming Zhou (1):
>   igt: add timeline test cases
> 
> Lionel Landwerlin (4):
>   drm-uapi: bump i915_drm.h for timeline semaphores
>   tests/syncobj_timeline: add more timeline tests
>   tests/i915/exec_fence: add timeline fence tests
>   tests/i915/gem_exec_fence: add engine chaining tests

I kinda got all blurry-eyed looking at this. I think all the gaps I've
spotted in Zhou's original series you've filled in, so I'm happy. On the
series:

Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch>

I think only thing missing here is do another CI run with kernel+igt side
together, using

https://intel-gfx-ci.01.org/test-with.html

to make sure the tests to all reflect current kernel uapi in the patches
and we haven't done any accident.

I think it'd would also be useful to get an ack from amd's side (or anyone
else who cares about timelin syncobj), so maybe just cc everyone (zhou,
bas/airlie from radv, maybe msm folks) for the final CI testing round. But
if you get nada, then no blocker imo, this has been bobbing around aimless
for way too long :-/

Cheers, Daniel

> 
>  include/drm-uapi/i915_drm.h |   65 +-
>  lib/igt_syncobj.c           |  236 ++++++
>  lib/igt_syncobj.h           |   22 +
>  lib/intel_reg.h             |    2 +
>  tests/i915/gem_exec_fence.c | 1319 ++++++++++++++++++++++++++++++
>  tests/meson.build           |    1 +
>  tests/syncobj_timeline.c    | 1537 +++++++++++++++++++++++++++++++++++
>  7 files changed, 3179 insertions(+), 3 deletions(-)
>  create mode 100644 tests/syncobj_timeline.c
> 
> --
> 2.27.0
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev