public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: "Zbigniew Kempczyński" <zbigniew.kempczynski@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Subject: [igt-dev] [PATCH i-g-t v26 09/17] tests/gem_caching|partial: adopt to batch flush function cleanup
Date: Tue,  4 Aug 2020 11:41:20 +0200	[thread overview]
Message-ID: <20200804094128.31242-10-zbigniew.kempczynski@intel.com> (raw)
In-Reply-To: <20200804094128.31242-1-zbigniew.kempczynski@intel.com>

intel_bb API has been cleaned so flush generates also BBE and executes
the batch. Remove redundant code to use flush properly.

Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
Cc: Dominik Grzegorzek <dominik.grzegorzek@intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
---
 tests/i915/gem_caching.c              | 5 -----
 tests/i915/gem_partial_pwrite_pread.c | 3 ---
 2 files changed, 8 deletions(-)

diff --git a/tests/i915/gem_caching.c b/tests/i915/gem_caching.c
index 1d8989db..23e42132 100644
--- a/tests/i915/gem_caching.c
+++ b/tests/i915/gem_caching.c
@@ -99,11 +99,6 @@ copy_bo(struct intel_bb *ibb, struct intel_buf *src, struct intel_buf *dst)
 	intel_bb_emit_reloc_fenced(ibb, src->handle,
 				   I915_GEM_DOMAIN_RENDER,
 				   0, 0, 0x0);
-
-	 /* Mark the end of the buffer. */
-	intel_bb_out(ibb, MI_BATCH_BUFFER_END);
-	intel_bb_ptr_align(ibb, 8);
-
 	intel_bb_flush_blit(ibb);
 	intel_bb_sync(ibb);
 }
diff --git a/tests/i915/gem_partial_pwrite_pread.c b/tests/i915/gem_partial_pwrite_pread.c
index b4bae9b6..b1028472 100644
--- a/tests/i915/gem_partial_pwrite_pread.c
+++ b/tests/i915/gem_partial_pwrite_pread.c
@@ -101,9 +101,6 @@ static void copy_bo(struct intel_buf *src, struct intel_buf *dst)
 				   I915_GEM_DOMAIN_RENDER,
 				   0, 0, 0x0);
 
-	intel_bb_out(ibb, MI_BATCH_BUFFER_END);
-	intel_bb_ptr_align(ibb, 8);
-
 	intel_bb_flush_blit(ibb);
 	intel_bb_sync(ibb);
 }
-- 
2.26.0

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

  parent reply	other threads:[~2020-08-04  9:41 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-04  9:41 [igt-dev] [PATCH i-g-t v26 00/17] Remove libdrm in rendercopy Zbigniew Kempczyński
2020-08-04  9:41 ` [igt-dev] [PATCH i-g-t v26 01/17] lib/intel_bufops: add mapping on cpu / device Zbigniew Kempczyński
2020-08-04  9:41 ` [igt-dev] [PATCH i-g-t v26 02/17] lib/intel_bufops: change in hw/sw tiling detection Zbigniew Kempczyński
2020-08-04  9:41 ` [igt-dev] [PATCH i-g-t v26 03/17] lib/intel_bufops: change stride requirements for Grantsdale Zbigniew Kempczyński
2020-08-04  9:41 ` [igt-dev] [PATCH i-g-t v26 04/17] lib/intel_bufops: add support for 64bit bpp Zbigniew Kempczyński
2020-08-04  9:41 ` [igt-dev] [PATCH i-g-t v26 05/17] lib/intel_batchbuffer: add new functions to support rendercopy Zbigniew Kempczyński
2020-08-04  9:41 ` [igt-dev] [PATCH i-g-t v26 06/17] lib/intel_batchbuffer: dump bb to base64 Zbigniew Kempczyński
2020-08-04  9:41 ` [igt-dev] [PATCH i-g-t v26 07/17] lib/intel_batchbuffer: use canonical addresses for 48bit ppgtt Zbigniew Kempczyński
2020-08-04  9:41 ` [igt-dev] [PATCH i-g-t v26 08/17] tests/api_intel_bb: test flags are cleared on bb reset Zbigniew Kempczyński
2020-08-04  9:41 ` Zbigniew Kempczyński [this message]
2020-08-04  9:41 ` [igt-dev] [PATCH i-g-t v26 10/17] lib/rendercopy: remove libdrm dependency Zbigniew Kempczyński
2020-08-04  9:41 ` [igt-dev] [PATCH i-g-t v26 11/17] tests/api_intel_bb: add render tests Zbigniew Kempczyński
2020-08-04  9:41 ` [igt-dev] [PATCH i-g-t v26 12/17] lib/igt_draw: remove libdrm dependency Zbigniew Kempczyński
2020-08-04  9:41 ` [igt-dev] [PATCH i-g-t v26 13/17] lib/igt_fb: Removal of " Zbigniew Kempczyński
2020-08-04  9:41 ` [igt-dev] [PATCH i-g-t v26 14/17] tests/gem|kms: remove libdrm dependency (batch 1) Zbigniew Kempczyński
2020-08-04  9:41 ` [igt-dev] [PATCH i-g-t v26 15/17] tests/gem|kms: remove libdrm dependency (batch 2) Zbigniew Kempczyński
2020-08-04  9:41 ` [igt-dev] [PATCH i-g-t v26 16/17] tools/intel_residency: adopt intel_residency to use bufops Zbigniew Kempczyński
2020-08-04  9:41 ` [igt-dev] [PATCH i-g-t v26 17/17] tests/perf: remove libdrm dependency for rendercopy Zbigniew Kempczyński
2020-08-04 10:21 ` [igt-dev] ✓ Fi.CI.BAT: success for Remove libdrm in rendercopy (rev25) Patchwork
2020-08-04 13:22 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2020-08-05 10:01   ` Zbigniew Kempczyński
2020-08-06  0:28     ` Umesh Nerlige Ramappa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200804094128.31242-10-zbigniew.kempczynski@intel.com \
    --to=zbigniew.kempczynski@intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox