public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Petri Latvala <petri.latvala@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Petri Latvala <petri.latvala@intel.com>
Subject: [igt-dev] [PATCH i-g-t] runner: Only claim the test was killed if it was killed
Date: Wed,  5 Aug 2020 13:59:00 +0300	[thread overview]
Message-ID: <20200805105900.29444-1-petri.latvala@intel.com> (raw)

If we don't have --abort=taint active and there is a kernel taint,
test exiting normally caused the runner to inject a "this test was
killed" message to the test's output. Make sure we only inject that if
we really did kill the test, and journal the test exit correctly as
well.

Same goes for the message for exceeding disk usage limits.

Signed-off-by: Petri Latvala <petri.latvala@intel.com>
Cc: Arkadiusz Hiler <arek@hiler.eu>
Cc: Lukasz Fiedorowicz <lukasz.fiedorowicz@intel.com>
---
 runner/executor.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/runner/executor.c b/runner/executor.c
index 0377195d..1688ae41 100644
--- a/runner/executor.c
+++ b/runner/executor.c
@@ -1071,7 +1071,7 @@ static int monitor_output(pid_t child,
 				 * the result an incomplete we avoid
 				 * journaling a timeout here.
 				 */
-				if (is_tainted(taints)) {
+				if (killed && is_tainted(taints)) {
 					exitline = EXECUTOR_EXIT;
 
 					/*
@@ -1096,7 +1096,7 @@ static int monitor_output(pid_t child,
 				 * Same goes for stopping because we
 				 * exceeded the disk usage limit.
 				 */
-				if (disk_usage_limit_exceeded(settings, disk_usage)) {
+				if (killed && disk_usage_limit_exceeded(settings, disk_usage)) {
 					exitline = EXECUTOR_EXIT;
 					dprintf(outputs[_F_OUT],
 						"\nrunner: This test was killed due to exceeding disk usage limit. "
-- 
2.20.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

             reply	other threads:[~2020-08-05 10:59 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-05 10:59 Petri Latvala [this message]
2020-08-05 12:13 ` [igt-dev] ✓ Fi.CI.BAT: success for runner: Only claim the test was killed if it was killed Patchwork
2020-08-05 14:01 ` [igt-dev] [PATCH i-g-t] " Lukasz Fiedorowicz
2020-08-05 16:26 ` [igt-dev] ✗ Fi.CI.IGT: failure for " Patchwork
2020-08-06  8:38   ` Petri Latvala
2020-08-06 16:37     ` Vudum, Lakshminarayana
2020-08-06 15:44 ` [igt-dev] ✓ Fi.CI.IGT: success " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200805105900.29444-1-petri.latvala@intel.com \
    --to=petri.latvala@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox