From: Petri Latvala <petri.latvala@intel.com>
To: Carlos Santa <carlos.santa@intel.com>
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH v2] tests: use an empty brace initializer
Date: Thu, 6 Aug 2020 11:43:50 +0300 [thread overview]
Message-ID: <20200806084350.GX20883@platvala-desk.ger.corp.intel.com> (raw)
In-Reply-To: <20200724070822.GY20883@platvala-desk.ger.corp.intel.com>
On Fri, Jul 24, 2020 at 10:08:22AM +0300, Petri Latvala wrote:
> On Thu, Jul 23, 2020 at 04:54:58PM -0700, Carlos Santa wrote:
> > In some sandboxes the toolchain complains about missing
> > braces around initializer, however, using an empty
> > initializer is enough to shut out the compiler.
> >
> > ../tests/kms_plane_cursor.c: In function '__real_main_302':
> > ../tests/kms_plane_cursor.c:305:2 error: missing braces around
> > initializer [-Werror=missing-braces]
> > data_t data = { 0 };
> >
> > v2:
> > Use an empty initializer { } instead of { 0 } <Petri, Latvala>
>
> Remove the comma, I'm "Petri Latvala" :)
>
>
> Reviewed-by: Petri Latvala <petri.latvala@intel.com>
And after a momentary brain failure, this is now also merged.
--
Petri Latvala
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2020-08-06 8:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-23 23:54 [igt-dev] [PATCH v2] tests: use an empty brace initializer Carlos Santa
2020-07-24 0:41 ` [igt-dev] ✗ GitLab.Pipeline: warning for " Patchwork
2020-07-24 0:57 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
2020-07-24 7:08 ` [igt-dev] [PATCH v2] " Petri Latvala
2020-08-06 8:43 ` Petri Latvala [this message]
2020-07-24 8:38 ` [igt-dev] ✗ Fi.CI.IGT: failure for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200806084350.GX20883@platvala-desk.ger.corp.intel.com \
--to=petri.latvala@intel.com \
--cc=carlos.santa@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox