From: Petri Latvala <petri.latvala@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t] intel-ci: Add testdisplay test to BAT
Date: Thu, 13 Aug 2020 12:12:33 +0300 [thread overview]
Message-ID: <20200813091233.GT7444@platvala-desk.ger.corp.intel.com> (raw)
In-Reply-To: <159730796702.14054.3936393887648687575@build.alporthouse.com>
On Thu, Aug 13, 2020 at 09:39:27AM +0100, Chris Wilson wrote:
> Quoting Swati Sharma (2020-08-06 12:08:03)
> > testdisplay should be added to BAT. testdisplay is considered
> > to be the most basic test to test display functionality.
> > With this test we will be able to test modesetting.
>
> Some might say that kms_setmode@basic provides the same coverage of
> basic modesetting. So what can be replaced? Does testdisplay have a good
> history of detecting bugs that others cannot? Does testdisplay have a
> good history of providing easy-to-debug results? [The latter is asking
> if it is a good primary test.] As I remember, testdisplay was relegated
> because it wasn't particularly helpful as anything other than an
> exhaustive sweep through all the modes.
I had similar recollections but testdisplay was never part of BAT,
says git log. I believe the original reason to not even consider it
was the runtime, which has been considerably impoved lately.
Other than that, the questions could use some answers.
(We should write those questions down in tests/intel-ci/README)
--
Petri Latvala
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
prev parent reply other threads:[~2020-08-13 9:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-06 11:08 [igt-dev] [PATCH i-g-t] intel-ci: Add testdisplay test to BAT Swati Sharma
2020-08-06 11:44 ` [igt-dev] ✓ Fi.CI.BAT: success for intel-ci: Add testdisplay test to BAT (rev2) Patchwork
2020-08-06 14:46 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2020-08-10 8:29 ` [igt-dev] [PATCH i-g-t] intel-ci: Add testdisplay test to BAT Sharma, Swati2
2020-08-13 7:24 ` Sharma, Swati2
2020-08-13 9:26 ` Peres, Martin
2020-08-14 12:17 ` Sharma, Swati2
2020-08-13 8:39 ` Chris Wilson
2020-08-13 9:12 ` Petri Latvala [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200813091233.GT7444@platvala-desk.ger.corp.intel.com \
--to=petri.latvala@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox