From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id C5E916E220 for ; Tue, 25 Aug 2020 19:14:11 +0000 (UTC) Received: by mail-qv1-f72.google.com with SMTP id h6so9440593qvz.14 for ; Tue, 25 Aug 2020 12:13:03 -0700 (PDT) Date: Tue, 25 Aug 2020 15:13:00 -0400 From: Jeremy Cline Message-ID: <20200825191300.GB274007@dev.jcline.org> References: <20200818193528.986926-1-lyude@redhat.com> MIME-Version: 1.0 In-Reply-To: <20200818193528.986926-1-lyude@redhat.com> Content-Disposition: inline Subject: Re: [igt-dev] [PATCH i-g-t v2 1/2] tests/kms_pipe_crc_basic: Use igt_display_require_output_on_pipe() List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Lyude Cc: igt-dev@lists.freedesktop.org List-ID: On Tue, Aug 18, 2020 at 03:35:27PM -0400, Lyude wrote: > From: Lyude Paul > > v2: Rebase > > Signed-off-by: Lyude Paul > --- It might be worth a short commit message body, something like "Refactor tests_read_crc() to use igt_display_require_output_on_pipe() rather than checking the validity of the pipe and output separately" maybe? > tests/kms_pipe_crc_basic.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/tests/kms_pipe_crc_basic.c b/tests/kms_pipe_crc_basic.c > index bb66bc6c..53d76df1 100644 > --- a/tests/kms_pipe_crc_basic.c > +++ b/tests/kms_pipe_crc_basic.c > @@ -65,15 +65,14 @@ static void test_bad_source(data_t *data) > static void test_read_crc(data_t *data, enum pipe pipe, unsigned flags) > { > igt_display_t *display = &data->display; > - igt_output_t *output = igt_get_single_output_for_pipe(display, pipe); > + igt_output_t *output; > igt_plane_t *primary; > drmModeModeInfo *mode; > igt_crc_t *crcs = NULL; > int c, j; > > - igt_require_pipe(display, pipe); > - igt_require_f(output, "No connector found for pipe %s\n", > - kmstest_pipe_name(pipe)); > + igt_display_require_output_on_pipe(display, pipe); > + output = igt_get_single_output_for_pipe(display, pipe); > > igt_display_reset(display); > igt_output_set_pipe(output, pipe); > -- > 2.26.2 > Looks like a good refactor to me: Reviewed-by: Jeremy Cline _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev