From: Uma Shankar <uma.shankar@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: marcin.bernatowicz@intel.com
Subject: [igt-dev] [PATCH i-g-t] tests/device_reset: Unload snd driver before i915 unbind
Date: Thu, 27 Aug 2020 21:02:28 +0530 [thread overview]
Message-ID: <20200827153228.13476-1-uma.shankar@intel.com> (raw)
Unload the snd module before unbinding i915. Audio holds
a wakeref which triggers a warning otherwise, resulting in
test failure.
Signed-off-by: Uma Shankar <uma.shankar@intel.com>
---
tests/device_reset.c | 17 +++++++++++++++++
1 file changed, 17 insertions(+)
diff --git a/tests/device_reset.c b/tests/device_reset.c
index b1181b3b..c979d46e 100644
--- a/tests/device_reset.c
+++ b/tests/device_reset.c
@@ -5,11 +5,13 @@
#include <fcntl.h>
#include <sys/ioctl.h>
#include <sys/stat.h>
+#include <signal.h>
#include "i915/gem.h"
#include "igt.h"
#include "igt_device_scan.h"
#include "igt_sysfs.h"
+#include "igt_kmod.h"
IGT_TEST_DESCRIPTION("Examine behavior of a driver on device sysfs reset");
@@ -164,6 +166,20 @@ static bool is_sysfs_reset_supported(int fd)
/* Unbind the driver from the device */
static void driver_unbind(struct device_fds *dev)
{
+ if (igt_kmod_is_loaded("snd_hda_intel")) {
+ igt_terminate_process(SIGTERM, "alsactl");
+
+ /* unbind snd_hda_intel */
+ kick_snd_hda_intel();
+
+ if (igt_kmod_unload("snd_hda_intel", 0)) {
+ igt_warn("Could not unload snd_hda_intel\n");
+ igt_kmod_list_loaded();
+ igt_lsof("/dev/snd");
+ return IGT_EXIT_FAILURE;
+ }
+ }
+
igt_debug("unbind the driver from the device\n");
igt_assert(igt_sysfs_set(dev->fds.drv_dir, "unbind",
dev->dev_bus_addr));
@@ -175,6 +191,7 @@ static void driver_bind(struct device_fds *dev)
igt_debug("rebind the driver to the device\n");
igt_abort_on_f(!igt_sysfs_set(dev->fds.drv_dir, "bind",
dev->dev_bus_addr), "driver rebind failed");
+ igt_kmod_load("snd_hda_intel", NULL);
}
/* Initiate device reset */
--
2.19.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next reply other threads:[~2020-08-27 14:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-27 15:32 Uma Shankar [this message]
2020-08-27 15:38 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/device_reset: Unload snd driver before i915 unbind Patchwork
2020-08-27 16:51 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200827153228.13476-1-uma.shankar@intel.com \
--to=uma.shankar@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=marcin.bernatowicz@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox