From: Uma Shankar <uma.shankar@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: marcin.bernatowicz@intel.com
Subject: [igt-dev] [PATCH i-g-t] tests/device_reset: Work around for driver unbind issue with audio
Date: Mon, 14 Sep 2020 18:18:18 +0530 [thread overview]
Message-ID: <20200914124818.11497-1-uma.shankar@intel.com> (raw)
Unbinding the i915 driver on some Haswell and Broadwell platforms with
Azalia audio results in a kernel WARNING on "i915 raw-wakerefs=1
wakelocks=1 on cleanup". The issue can be worked around by manually
enabling runtime power management for the conflicting audio adapter.
Use that method but also display a warning to preserve visibility of
the issue. Also tag the workaround with a FIXME comment.
Signed-off-by: Uma Shankar <uma.shankar@intel.com>
Signed-off-by: Janusz Krzysztofik <janusz.krzysztofik@linux.intel.com>
---
tests/device_reset.c | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/tests/device_reset.c b/tests/device_reset.c
index b1181b3b..9cb59ee4 100644
--- a/tests/device_reset.c
+++ b/tests/device_reset.c
@@ -232,9 +232,20 @@ static void set_device_filter(const char* dev_path)
static void unbind_reset_rebind(struct device_fds *dev)
{
+ uint32_t devid = intel_get_drm_devid(dev->fds.dev);
igt_debug("close the device\n");
close_if_opened(&dev->fds.dev);
+ /**
+ * FIXME: Unbinding the i915 driver on some platforms with Azalia audio
+ * results in a kernel WARN on "i915 raw-wakerefs=1 wakelocks=1 on cleanup".
+ * The below CI friendly user level workaround prevents the warning from
+ * appearing. Drop this hack as soon as this is fixed in the kernel.
+ */
+ if (igt_warn_on_f((bool) IS_HASWELL(devid) || IS_BROADWELL(devid),
+ "Manually enabling audio PM to work around a kernel WARN\n"))
+ igt_pm_enable_audio_runtime_pm();
+
driver_unbind(dev);
initiate_device_reset(dev);
--
2.19.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next reply other threads:[~2020-09-14 12:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-14 12:48 Uma Shankar [this message]
2020-09-14 12:26 ` [igt-dev] [PATCH i-g-t] tests/device_reset: Work around for driver unbind issue with audio Janusz Krzysztofik
2020-09-14 12:51 ` Shankar, Uma
-- strict thread matches above, loose matches on Subject: below --
2020-09-14 13:36 Uma Shankar
2020-09-14 19:19 ` Janusz Krzysztofik
2020-09-14 20:47 ` Vudum, Lakshminarayana
2020-09-15 6:18 ` Janusz Krzysztofik
2020-09-15 6:29 ` Janusz Krzysztofik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200914124818.11497-1-uma.shankar@intel.com \
--to=uma.shankar@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=marcin.bernatowicz@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox