From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id 35D256F5CA for ; Thu, 22 Oct 2020 10:37:06 +0000 (UTC) Date: Thu, 22 Oct 2020 13:37:02 +0300 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Message-ID: <20201022103702.GJ6112@intel.com> References: <20201021085956.5bgbdcmoh357v3tx@smtp.gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201021085956.5bgbdcmoh357v3tx@smtp.gmail.com> Subject: Re: [igt-dev] [PATCH i-g-t v2] tests/kms_cursor_crc: refactoring cursor-alpha subtests List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Melissa Wen Cc: igt-dev@lists.freedesktop.org, Petri Latvala , kernel-usp@googlegroups.com List-ID: On Wed, Oct 21, 2020 at 05:59:56AM -0300, Melissa Wen wrote: > Considering just a fully opaque or fully transparent cursor is not enough > to check the composition of an ARGB cursor plane. For example, the cairo > ARGB32 format uses pre-multiplied alpha, and this representation may only > be evident when testing a translucent cursor. > = > Therefore, this patch refactors the cursor-alpha-opaque and > cursor-alpha-transparent subtests into just one subtest (cursor-alpha) > that checks the alpha blending of a white cursor, with different alpha > values, in the primary plane. This refactoring also generates some setup > stuffs savings. Black background means you can't actually tell the difference between premultiplied blending and no blending. Oh, I guess restore_image() does end up painting the test pattern into the primary plane's fb? Are we guaranteed to position the cursor over some non-black parts? The other obvious concern is whether hardware and software blending will produce the exact same results or not. I do see you use 1/4 steps for the alpha, which I guess can make that more likely. Side note: data->primary_fb[RESTOREBUFFER] looks to be dead weight > = > v2: > - debug log states the alpha whenever CRC mismatch (Arek) > - checking all alpha values before asserting the result (Arek) > = > Signed-off-by: Melissa Wen > --- > tests/kms_cursor_crc.c | 87 ++++++++++++++++++++++-------------------- > 1 file changed, 45 insertions(+), 42 deletions(-) > = > diff --git a/tests/kms_cursor_crc.c b/tests/kms_cursor_crc.c > index 0be8f7f8..83c74a69 100644 > --- a/tests/kms_cursor_crc.c > +++ b/tests/kms_cursor_crc.c > @@ -428,65 +428,73 @@ static void prepare_crtc(data_t *data, igt_output_t= *output, > igt_pipe_crc_start(data->pipe_crc); > } > = > -static void test_cursor_alpha(data_t *data, double a) > +static void test_cursor_alpha(data_t *data) > { > igt_display_t *display =3D &data->display; > igt_pipe_crc_t *pipe_crc =3D data->pipe_crc; > - igt_crc_t crc, ref_crc; > + igt_crc_t crc[5], ref_crc; > cairo_t *cr; > uint32_t fb_id; > int curw =3D data->curw; > int curh =3D data->curh; > + int i, index; > + double alpha; > + bool mismatch =3D false; > = > - /* Alpha cursor fb with white color */ > + /* Alpha cursor fb */ > fb_id =3D igt_create_fb(data->drm_fd, curw, curh, > DRM_FORMAT_ARGB8888, > LOCAL_DRM_FORMAT_MOD_NONE, > &data->fb); > igt_assert(fb_id); > + > + /* > + * Hardware Test > + * With the cursor enabled, get the PF CRCs from the composition with a > + * white cursor with different alpha values. > + */ > cr =3D igt_get_cairo_ctx(data->drm_fd, &data->fb); > - igt_paint_color_alpha(cr, 0, 0, curw, curh, 1.0, 1.0, 1.0, a); > - igt_put_cairo_ctx(cr); > + cairo_set_operator (cr, CAIRO_OPERATOR_SOURCE); > = > - /* Hardware Test - enable cursor and get PF CRC */ > cursor_enable(data); > - igt_display_commit(display); > - igt_wait_for_vblank(data->drm_fd, > - display->pipes[data->pipe].crtc_offset); > - igt_pipe_crc_get_current(data->drm_fd, pipe_crc, &crc); > + for (i =3D 0, alpha =3D 1.0; alpha >=3D 0.0; alpha -=3D 0.25, i++) { > + igt_paint_color_alpha(cr, 0, 0, curw, curh, 1.0, 1.0, 1.0, alpha); > + > + igt_display_commit(display); > + igt_wait_for_vblank(data->drm_fd, > + display->pipes[data->pipe].crtc_offset); > + igt_pipe_crc_get_current(data->drm_fd, pipe_crc, &crc[i]); > + } > + igt_put_cairo_ctx(cr); > = > cursor_disable(data); > igt_remove_fb(data->drm_fd, &data->fb); > = > - /* Software Test - render cursor in software, drawn it directly on PF */ > + /* Software Test - render cursor in software, drawn it directly on PF*/ > cr =3D igt_get_cairo_ctx(data->drm_fd, &data->primary_fb[FRONTBUFFER]); > - igt_paint_color_alpha(cr, 0, 0, curw, curh, 1.0, 1.0, 1.0, a); > - igt_put_cairo_ctx(cr); > - > - igt_display_commit(display); > - igt_wait_for_vblank(data->drm_fd, > - display->pipes[data->pipe].crtc_offset); > - igt_pipe_crc_get_current(data->drm_fd, pipe_crc, &ref_crc); > = > - /* Compare CRC from Hardware/Software tests */ > - igt_assert_crc_equal(&crc, &ref_crc); > + for (i =3D 0, alpha =3D 1.0; alpha >=3D 0.0; alpha -=3D 0.25, i++) { > + igt_paint_color_alpha(cr, 0, 0, curw, curh, 1.0, 1.0, 1.0, alpha); > = > - /*Clear Screen*/ > - cr =3D igt_get_cairo_ctx(data->drm_fd, &data->primary_fb[FRONTBUFFER]); > - igt_paint_color(cr, 0, 0, data->screenw, data->screenh, > - 0.0, 0.0, 0.0); > - igt_put_cairo_ctx(cr); > -} > + igt_display_commit(display); > + igt_wait_for_vblank(data->drm_fd, > + display->pipes[data->pipe].crtc_offset); > + igt_pipe_crc_get_current(data->drm_fd, pipe_crc, &ref_crc); > = > -static void test_cursor_transparent(data_t *data) > -{ > - test_cursor_alpha(data, 0.0); > + /* Compare CRC from Hardware/Software tests */ > + if (igt_find_crc_mismatch(&crc[i], &ref_crc, &index)) { > + mismatch =3D true; > + igt_debug("CRC mismatch for alpha %.2f: 0x%x !=3D 0x%x\n", > + alpha, crc[i].crc[index], ref_crc.crc[index]); > + } > = > -} > + /*Clear Screen*/ > + igt_paint_color(cr, 0, 0, data->screenw, data->screenh, > + 0.0, 0.0, 0.0); > + } > + igt_put_cairo_ctx(cr); > = > -static void test_cursor_opaque(data_t *data) > -{ > - test_cursor_alpha(data, 1.0); > + igt_assert_f(!mismatch, "At least one CRC mismatch detected\n"); > } > = > static void run_test(data_t *data, void (*testfunc)(data_t *), int curso= r_w, int cursor_h) > @@ -655,15 +663,10 @@ static void run_tests_on_pipe(data_t *data, enum pi= pe pipe) > run_test(data, test_cursor_size, > data->cursor_max_w, data->cursor_max_h); > = > - igt_describe("Validates the composition of a fully opaque cursor " > - "plane, i.e., alpha channel equal to 1.0."); > - igt_subtest_f("pipe-%s-cursor-alpha-opaque", kmstest_pipe_name(pipe)) > - run_test(data, test_cursor_opaque, data->cursor_max_w, data->cursor_ma= x_h); > - > - igt_describe("Validates the composition of a fully transparent cursor " > - "plane, i.e., alpha channel equal to 0.0."); > - igt_subtest_f("pipe-%s-cursor-alpha-transparent", kmstest_pipe_name(pip= e)) > - run_test(data, test_cursor_transparent, data->cursor_max_w, data->curs= or_max_h); > + igt_describe("Validates the composition of alpha cursor plane " > + "from fully opaque to fully transparent alpha range"); > + igt_subtest_f("pipe-%s-cursor-alpha", kmstest_pipe_name(pipe)) > + run_test(data, test_cursor_alpha, data->cursor_max_w, data->cursor_max= _h); > = > igt_fixture > create_cursor_fb(data, data->cursor_max_w, data->cursor_max_h); > -- = > 2.28.0 > = > _______________________________________________ > igt-dev mailing list > igt-dev@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/igt-dev -- = Ville Syrj=E4l=E4 Intel _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev