From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8C98E89F24 for ; Wed, 11 Nov 2020 10:26:25 +0000 (UTC) Date: Wed, 11 Nov 2020 12:26:15 +0200 From: Petri Latvala Message-ID: <20201111102615.GJ7444@platvala-desk.ger.corp.intel.com> References: <20201106092757.21505-1-nidhi1.gupta@intel.com> <20201106093436.GV7444@platvala-desk.ger.corp.intel.com> <150da36c-cb0a-f308-c6b1-bf2cf336c9ae@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <150da36c-cb0a-f308-c6b1-bf2cf336c9ae@intel.com> Subject: Re: [igt-dev] [RFC, i-g-t] Added dynamic Subtest List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Karthik B S Cc: igt-dev@lists.freedesktop.org, nidhi1.gupta@intel.com List-ID: On Wed, Nov 11, 2020 at 03:12:12PM +0530, Karthik B S wrote: > On 11/6/2020 3:04 PM, Petri Latvala wrote: > > On Fri, Nov 06, 2020 at 02:57:57PM +0530, nidhi1.gupta@intel.com wrote: > > > From: Nidhi Gupta > > > > > > Signed-off-by: Nidhi Gupta > > > --- > > > tests/kms_atomic_transition.c | 8 ++++---- > > > 1 file changed, 4 insertions(+), 4 deletions(-) > > > > > > diff --git a/tests/kms_atomic_transition.c b/tests/kms_atomic_transition.c > > > index a71bbe10..aa2afe02 100644 > > > --- a/tests/kms_atomic_transition.c > > > +++ b/tests/kms_atomic_transition.c > > > @@ -1025,16 +1025,16 @@ igt_main > > > run_transition_test(&display, pipe, output, TRANSITION_MODESET_DISABLE, false, false); > > > for (i = 1; i <= IGT_MAX_PIPES; i++) { > > Since we're now anyway planning to use dynamic subtests for this, > > Could we just have a count of the number of outputs connected and use this, > instead of using IGT_MAX_PIPES to populate the subtests and eventually > skipping them? Yeah that sounds proper actually. So igt_subtest_with_dynamic("modeset-transitions"), with for_each_pipe, or for_each_pipe_with_single_output, or for_each_connected_output, based on what kind of coverage is needed, and igt_dynamic_f for each. -- Petri Latvala > > @Petri, > > Does this sound good? > > Thanks, > Karthik.B.S > > > - igt_subtest_f("%ix-modeset-transitions", i) > > > + igt_subtest_with_dynamic_f("%ix-modeset-transitions", i) > > > run_modeset_transition(&display, i, false, false); > > > - igt_subtest_f("%ix-modeset-transitions-nonblocking", i) > > > + igt_subtest_with_dynamic_f("%ix-modeset-transitions-nonblocking", i) > > > run_modeset_transition(&display, i, true, false); > > > - igt_subtest_f("%ix-modeset-transitions-fencing", i) > > > + igt_subtest_with_dynamic_f("%ix-modeset-transitions-fencing", i) > > > run_modeset_transition(&display, i, false, true); > > > - igt_subtest_f("%ix-modeset-transitions-nonblocking-fencing", i) > > > + igt_subtest_with_dynamic_f("%ix-modeset-transitions-nonblocking-fencing", i) > > > run_modeset_transition(&display, i, true, true); > > Where are the igt_dynamic() blocks for these? > > > > > > -- > > Petri Latvala > > _______________________________________________ > > igt-dev mailing list > > igt-dev@lists.freedesktop.org > > https://lists.freedesktop.org/mailman/listinfo/igt-dev > > _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev