Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Kunal Joshi <kunal@intel.com>
To: "B S, Karthik" <karthik.b.s@intel.com>, igt-dev@lists.freedesktop.org
Cc: , Zanoni@intel.com, SowmyaX <sowmyax.kaparthi@intel.com>,
	Kaparthi@intel.com
Subject: Re: [igt-dev] FW: [PATCH i-g-t] tests/kms_async_flips: Modify assert to fix failure seen on few platforms
Date: Wed, 18 Nov 2020 09:51:45 +0530	[thread overview]
Message-ID: <20201118042145.GA49735@intel.com> (raw)
In-Reply-To: <2c25c93b7a4048e9a82eee9fccd88c9b@intel.com>

Hi,

> Failure is seen on CI on few platforms as one of the flips in between is
> taking longer time. To fix this, added a check to assert for individual
> flips only for the alternate-sync-async-flip subtest. In the
> async-flip-with-page-flip-events subtest we anyway check the overall FPS
> at the end, so we do not need a check for individual flips and this should
> take care of some random flip taking more time in between.
> 
> Also, reduced the MIN_FLIPS_PER_FRAME from 8 to 5 based on the failure
> seen in CI.
> 
> Bug: https://gitlab.freedesktop.org/drm/intel/-/issues/2521
> 
> Signed-off-by: Karthik B S <karthik.b.s@intel.com>
> ---
>  tests/kms_async_flips.c | 12 +++++++-----
>  1 file changed, 7 insertions(+), 5 deletions(-)
> 
Reviewed-by: Kunal Joshi <kunal1.joshi@intel.com> 
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

      parent reply	other threads:[~2020-11-18  4:20 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-12  9:40 [igt-dev] [PATCH i-g-t] tests/kms_async_flips: Modify assert to fix failure seen on few platforms Karthik B S
2020-10-12 11:13 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2020-10-12 16:56 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
     [not found]   ` <26a7a2dc43824cbb88294534d80645e1@intel.com>
     [not found]     ` <1377dfe2e86c489abc16bcebeced7b33@intel.com>
2020-11-20  4:33       ` Kunal Joshi
     [not found] ` <2c25c93b7a4048e9a82eee9fccd88c9b@intel.com>
2020-11-18  4:21   ` Kunal Joshi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201118042145.GA49735@intel.com \
    --to=kunal@intel.com \
    --cc=Kaparthi@intel.com \
    --cc=Zanoni@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=karthik.b.s@intel.com \
    --cc=sowmyax.kaparthi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox