Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Arjun Melkaveri <arjun.melkaveri@intel.com>
To: arjun.melkaveri@intel.com, igt-dev@lists.freedesktop.org,
	tvrtko.ursulin@intel.com
Subject: [igt-dev] [PATCH i-g-t] gem_exec_reloc & gem_shrink: Added gem_require_mappable_ggtt to check mappable aperture
Date: Mon, 30 Nov 2020 07:33:02 +0530	[thread overview]
Message-ID: <20201130020302.24843-1-arjun.melkaveri@intel.com> (raw)

Added gem_require_mappable_ggtt to check mappable aperture.
This is to avoid any test crash that might happen
if mappable aperture is not avilable.

Cc: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Signed-off-by: Arjun Melkaveri <arjun.melkaveri@intel.com>
---
 tests/i915/gem_exec_reloc.c | 3 +++
 tests/i915/gem_shrink.c     | 2 ++
 2 files changed, 5 insertions(+)

diff --git a/tests/i915/gem_exec_reloc.c b/tests/i915/gem_exec_reloc.c
index 8dcb24a6..596b1157 100644
--- a/tests/i915/gem_exec_reloc.c
+++ b/tests/i915/gem_exec_reloc.c
@@ -1217,6 +1217,7 @@ igt_main
 			if (!(f->flags & NORELOC)) {
 				igt_subtest_f("%srange%s",
 					      f->basic ? "basic-" : "", f->name) {
+					gem_require_mappable_ggtt(fd);
 					igt_while_interruptible(f->flags & INTERRUPTIBLE)
 						basic_range(fd, f->flags);
 				}
@@ -1264,6 +1265,7 @@ igt_main
 	}
 
 	igt_subtest_with_dynamic("basic-spin") {
+
 		__for_each_physical_engine(fd, e) {
 			igt_dynamic_f("%s", e->name)
 				active_spin(fd, e->flags);
@@ -1278,6 +1280,7 @@ igt_main
 	}
 
 	igt_subtest_with_dynamic("basic-many-active") {
+		gem_require_mappable_ggtt(fd);
 		__for_each_physical_engine(fd, e) {
 			igt_dynamic_f("%s", e->name)
 				many_active(fd, e->flags);
diff --git a/tests/i915/gem_shrink.c b/tests/i915/gem_shrink.c
index dba62c8f..094975af 100644
--- a/tests/i915/gem_shrink.c
+++ b/tests/i915/gem_shrink.c
@@ -432,6 +432,8 @@ igt_main
 		fd = drm_open_driver(DRIVER_INTEL);
 		igt_require_gem(fd);
 
+		gem_require_mappable_ggtt(fd);
+
 		/*
 		 * Spawn enough processes to use all memory, but each only
 		 * uses half the available mappable aperture ~128MiB.
-- 
2.25.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

             reply	other threads:[~2020-11-30  2:07 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-30  2:03 Arjun Melkaveri [this message]
2020-11-30 10:04 ` [igt-dev] [PATCH i-g-t] gem_exec_reloc & gem_shrink: Added gem_require_mappable_ggtt to check mappable aperture Tvrtko Ursulin
2020-11-30 10:12   ` Chris Wilson
2020-11-30 12:09     ` Tvrtko Ursulin
2020-12-02 11:05       ` Melkaveri, Arjun
2020-12-02 11:29         ` Chris Wilson
2020-12-02 15:17           ` Melkaveri, Arjun
2020-11-30 14:10 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2020-12-01  3:26 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201130020302.24843-1-arjun.melkaveri@intel.com \
    --to=arjun.melkaveri@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=tvrtko.ursulin@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox