Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Anshuman Gupta <anshuman.gupta@intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [PATCH i-g-t 3/6] i915/i915_pm_rpm: enable modeset-pc8-residency-stress test
Date: Wed,  9 Dec 2020 21:36:39 +0530	[thread overview]
Message-ID: <20201209160642.6317-4-anshuman.gupta@intel.com> (raw)
In-Reply-To: <20201209160642.6317-1-anshuman.gupta@intel.com>

Enable modeset-pc8-residency-stress to check PC8 residency
after modeset.
Negative testing of PC8 residency on HASWELL/BROADWELL while
display being "on" is removed as it saves CI time and there is
no ROI of such testing.

Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com>
---
 tests/i915/i915_pm_rpm.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/tests/i915/i915_pm_rpm.c b/tests/i915/i915_pm_rpm.c
index 42bc44d9..34ec9a6d 100644
--- a/tests/i915/i915_pm_rpm.c
+++ b/tests/i915/i915_pm_rpm.c
@@ -878,8 +878,10 @@ static void modeset_subtest(enum screen_type type, int rounds, int wait_flags)
 {
 	int i;
 
-	if (wait_flags & WAIT_PC8_RES)
+	if (wait_flags & WAIT_PC8_RES) {
 		igt_require(has_pc8);
+		igt_require(setup_powertop());
+	}
 
 	if (wait_flags & WAIT_EXTRA)
 		rounds /= 2;
@@ -902,8 +904,6 @@ static void modeset_subtest(enum screen_type type, int rounds, int wait_flags)
 		igt_require(enable_one_screen_with_type(&ms_data, type));
 		if (wait_flags & WAIT_STATUS)
 			igt_assert(wait_for_active());
-		if (wait_flags & WAIT_PC8_RES)
-			igt_assert(!pc8_plus_residency_changed(5));
 		if (wait_flags & WAIT_EXTRA)
 			sleep(5);
 	}
-- 
2.26.2

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

  parent reply	other threads:[~2020-12-09 16:22 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-09 16:06 [igt-dev] [PATCH i-g-t 0/6] PC state igt test Anshuman Gupta
2020-12-09 16:06 ` [igt-dev] [PATCH i-g-t 1/6] i915/i915_pm_rpm: Enable PC8+ residency test Anshuman Gupta
2020-12-09 16:06 ` [igt-dev] [PATCH i-g-t 2/6] i915/i915_pm_rpm.c: create PC state subtest group Anshuman Gupta
2020-12-09 16:25   ` Chris Wilson
2020-12-09 16:25     ` Anshuman Gupta
2020-12-09 16:47       ` Chris Wilson
2020-12-10  5:02         ` Anshuman Gupta
2020-12-10  7:42           ` Chris Wilson
2021-01-21 19:55             ` Rodrigo Vivi
2021-01-22  5:46               ` Gupta, Anshuman
2020-12-09 16:06 ` Anshuman Gupta [this message]
2020-12-09 16:06 ` [igt-dev] [PATCH i-g-t 4/6] i915/i915_pm_rpm: gem-execbuf-stress-pc8 use powetop Anshuman Gupta
2020-12-09 16:06 ` [igt-dev] [PATCH i-g-t 5/6] i915/i915_pm_rpm: Add PC10 display off test Anshuman Gupta
2020-12-09 16:06 ` [igt-dev] [PATCH i-g-t 6/6] i915/i915_pm_rpm: Add PC10 idle display on test Anshuman Gupta
2020-12-09 17:15 ` [igt-dev] ✗ Fi.CI.BAT: failure for PC state igt test Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201209160642.6317-4-anshuman.gupta@intel.com \
    --to=anshuman.gupta@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox