From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1anam02on2058.outbound.protection.outlook.com [40.107.96.58]) by gabe.freedesktop.org (Postfix) with ESMTPS id 85ED36EA25 for ; Fri, 18 Jun 2021 14:29:08 +0000 (UTC) From: Anson Jacob Date: Fri, 18 Jun 2021 10:28:54 -0400 Message-ID: <20210618142855.5750-4-Anson.Jacob@amd.com> In-Reply-To: <20210618142855.5750-1-Anson.Jacob@amd.com> References: <20210618142855.5750-1-Anson.Jacob@amd.com> MIME-Version: 1.0 Subject: [igt-dev] [PATCH i-g-t 3/4] tests/kms_plane_multiple: Start continuous CRC capture after commit List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: igt-dev@lists.freedesktop.org Cc: Petri Latvala , Anson Jacob , Victor Lu , Mark Yacoub List-ID: From: Victor Lu atomic-pipe-a-tiling-none fails on Raven because it fails to read the CRC when there is no CRC generated (zeroed framebuffer). Move igt_pipe_crc_start to be after the first nonzero FB commit. Signed-off-by: Victor Lu Acked-by: Anson Jacob Cc: Petri Latvala Cc: Rodrigo Siqueira Cc: Harry Wentland Cc: Mark Yacoub --- tests/kms_plane_multiple.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/tests/kms_plane_multiple.c b/tests/kms_plane_multiple.c index 93c6ea7d269d..4424b864b2d6 100644 --- a/tests/kms_plane_multiple.c +++ b/tests/kms_plane_multiple.c @@ -288,6 +288,7 @@ test_plane_position_with_output(data_t *data, enum pipe pipe, igt_plane_t *plane; int i; int err, c = 0; + int crc_enabled = 0; int iterations = opt.iterations < 1 ? 1 : opt.iterations; bool loop_forever; char info[256]; @@ -327,14 +328,16 @@ test_plane_position_with_output(data_t *data, enum pipe pipe, igt_output_name(output), kmstest_pipe_name(pipe), c, info, opt.seed); - igt_pipe_crc_start(data->pipe_crc); - i = 0; while (i < iterations || loop_forever) { /* randomize planes and set up the holes */ prepare_planes(data, pipe, &blue, tiling, c, output); igt_display_commit2(&data->display, COMMIT_ATOMIC); + if (!crc_enabled) { + igt_pipe_crc_start(data->pipe_crc); + crc_enabled = 1; + } igt_pipe_crc_get_current(data->display.drm_fd, data->pipe_crc, &crc); -- 2.25.1 _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev