From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Wed, 14 Jul 2021 15:24:06 +0530 From: Ramalingam C Message-ID: <20210714095406.GA27868@intel.com> References: <20210707105238.1694091-1-matthew.auld@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210707105238.1694091-1-matthew.auld@intel.com> Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_addfb_basic: pass the actual fd to gem_has_lmem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Matthew Auld Cc: igt-dev@lists.freedesktop.org, Mohammed Khajapasha , intel-gfx@lists.freedesktop.org, Latvala Petri List-ID: On 2021-07-07 at 11:52:38 +0100, Matthew Auld wrote: > Currently we pass the devid as if it were the fd, which doesn't work. > > Signed-off-by: Matthew Auld LGTM. Reviewed-by: Ramalingam C > Cc: Mohammed Khajapasha > Cc: Latvala Petri > Cc: Michael J. Ruhl > --- > tests/kms_addfb_basic.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/tests/kms_addfb_basic.c b/tests/kms_addfb_basic.c > index 91fb6ac9..eff1d9b2 100644 > --- a/tests/kms_addfb_basic.c > +++ b/tests/kms_addfb_basic.c > @@ -150,13 +150,11 @@ static void invalid_tests(int fd) > igt_describe("Check if addfb2 with a system memory gem object " > "fails correctly if device requires local memory framebuffers"); > igt_subtest("invalid-smem-bo-on-discrete") { > - int devid; > uint32_t handle, stride; > uint64_t size; > > igt_require_intel(fd); > - devid = intel_get_drm_devid(fd); > - igt_require(gem_has_lmem(devid)); > + igt_require(gem_has_lmem(fd)); > igt_calc_fb_size(fd, f.width, f.height, > DRM_FORMAT_XRGB8888, 0, &size, &stride); > handle = gem_create_in_memory_regions(fd, size, REGION_SMEM); > -- > 2.26.3 > > _______________________________________________ > igt-dev mailing list > igt-dev@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/igt-dev _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev