Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Vidya Srinivas <vidya.srinivas@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: kunal1.joshi@intel.com, petri.latvala@intel.com,
	juha-pekka.heikkila@intel.com,
	Lin Charlton <charlton.lin@intel.com>
Subject: [igt-dev] [PATCH i-g-t] tests/kms_big_fb: Fix hw stride length tests
Date: Fri, 23 Jul 2021 15:08:44 +0530	[thread overview]
Message-ID: <20210723093844.22352-1-vidya.srinivas@intel.com> (raw)

We see the HW stride length tests are crashing
when run in sequence. Individually, they PASS.
This is happening due to missing data.ibb creation
before the test_scanout. Patch fixes the same.

Signed-off-by: Lin Charlton <charlton.lin@intel.com>
Signed-off-by: Vidya Srinivas <vidya.srinivas@intel.com>
---
 tests/kms_big_fb.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/tests/kms_big_fb.c b/tests/kms_big_fb.c
index c6f374bdd073..91439ceb34b6 100644
--- a/tests/kms_big_fb.c
+++ b/tests/kms_big_fb.c
@@ -978,7 +978,9 @@ igt_main
 						igt_require(data.format == DRM_FORMAT_C8 ||
 							igt_fb_supported_format(data.format));
 						igt_require(igt_display_has_format_mod(&data.display, data.format, data.modifier));
+						data.ibb = intel_bb_create(data.drm_fd, 4096);
 						test_scanout(&data);
+						intel_bb_destroy(data.ibb);
 					}
 
 					// async flip doesn't support linear fbs.
@@ -994,7 +996,9 @@ igt_main
 							igt_require(igt_display_has_format_mod(&data.display, data.format, data.modifier));
 							igt_require_f(data.async_flip_support, "Async Flip is not supported\n");
 							data.max_hw_fb_width = min(data.hw_stride / (formats[j].bpp >> 3), data.max_fb_width);
+							data.ibb = intel_bb_create(data.drm_fd, 4096);
 							test_scanout(&data);
+							intel_bb_destroy(data.ibb);
 					}
 					data.async_flip_test = false;
 				}
-- 
2.32.0

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

             reply	other threads:[~2021-07-23  9:49 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-23  9:38 Vidya Srinivas [this message]
2021-07-23 14:07 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_big_fb: Fix hw stride length tests Patchwork
2021-07-23 20:14 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2021-07-26  6:25 ` [igt-dev] [PATCH i-g-t] " Srinivas, Vidya
2021-07-26 19:48 ` Shankar, Uma
2021-07-26 19:56   ` Shankar, Uma
2021-07-27 15:09     ` Srinivas, Vidya
2021-07-27 14:57 ` Vidya Srinivas
2021-07-27 18:54   ` Vidya Srinivas
2021-07-29  7:39     ` Srinivas, Vidya
2021-07-29 16:25       ` Vudum, Lakshminarayana
2021-07-29 16:30         ` Srinivas, Vidya
2021-07-30  9:17     ` [igt-dev] [PATCH i-g-t] tests/kms_big_fb: Fix crash in " Vidya Srinivas
2021-07-30 12:44       ` [igt-dev] [PATCH i-g-t] tests/kms_big_fb: Fix hw stride/async subtests for 5.4 kernel Vidya Srinivas
2021-08-02 12:45         ` Juha-Pekka Heikkila
2021-07-27 17:09 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_big_fb: Fix hw stride length tests (rev2) Patchwork
2021-07-27 19:52 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_big_fb: Fix hw stride length tests (rev3) Patchwork
2021-07-27 22:34 ` [igt-dev] ✗ GitLab.Pipeline: warning " Patchwork
2021-07-28  1:26 ` [igt-dev] ✗ Fi.CI.IGT: failure for tests/kms_big_fb: Fix hw stride length tests (rev2) Patchwork
2021-07-28  5:54 ` [igt-dev] ✗ Fi.CI.IGT: failure for tests/kms_big_fb: Fix hw stride length tests (rev3) Patchwork
2021-07-29 15:36 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
2021-07-29 15:46 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2021-07-30  1:34 ` Patchwork
2021-07-30 11:59 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_big_fb: Fix hw stride length tests (rev4) Patchwork
2021-07-30 13:31 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_big_fb: Fix hw stride length tests (rev5) Patchwork
2021-07-30 14:51 ` [igt-dev] ✗ GitLab.Pipeline: warning for tests/kms_big_fb: Fix hw stride length tests (rev4) Patchwork
2021-07-30 19:59 ` [igt-dev] ✓ Fi.CI.IGT: success " Patchwork
2021-07-30 22:16 ` [igt-dev] ✓ Fi.CI.IGT: success for tests/kms_big_fb: Fix hw stride length tests (rev5) Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210723093844.22352-1-vidya.srinivas@intel.com \
    --to=vidya.srinivas@intel.com \
    --cc=charlton.lin@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=juha-pekka.heikkila@intel.com \
    --cc=kunal1.joshi@intel.com \
    --cc=petri.latvala@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox