From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by gabe.freedesktop.org (Postfix) with ESMTPS id 102CD6EE52 for ; Fri, 17 Sep 2021 16:19:04 +0000 (UTC) Date: Fri, 17 Sep 2021 09:14:05 -0700 From: Matthew Brost Message-ID: <20210917161405.GA1054@jons-linux-dev-box> References: <20210916180301.6791-1-matthew.brost@intel.com> <20210916180301.6791-4-matthew.brost@intel.com> <900219d9-5e70-faa1-bb25-7f01c2d14738@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: Subject: Re: [igt-dev] [PATCH i-g-t 3/3] i915/sysfs_preempt_timeout: Update test to work with GuC submission List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Tvrtko Ursulin Cc: John Harrison , igt-dev@lists.freedesktop.org, daniele.ceraolospurio@intel.com List-ID: On Fri, Sep 17, 2021 at 08:36:19AM +0100, Tvrtko Ursulin wrote: >=20 > On 16/09/2021 21:49, John Harrison wrote: > > On 9/16/2021 11:03, Matthew Brost wrote: > > > Increase reset timeout as resets can take a bit longer with GuC > > > submission because an error capture is done and with a large GuC log = (16 > > > MB) these take a while. > > >=20 > > > Don't run 'off' section as with GuC submission we don't handle > > > dynamically changing the preemption timeout from 'off' to 'on' on a > > > currently running context. This is not bug in GuC submission rather an > > > architectural decision to not implement this as there is no user aside > > > from IGTs. We don't run this section on any gen12+ platforms as we > > > assume GuC submission on these platforms. >=20 > Tigerlake as well or not care about removing the coverage from it? >=20 Tigerlake is skipped as well. I don't think we care about removing coverage as this section isn't really a real world use case. e.g. I don't a UMD will ever: Turn off preemption Create and submit a contet Turn on preemption and expect an existing context to have the new preemptio= n value Matt > Regards, >=20 > Tvrtko >=20 > > >=20 > > > Signed-off-by: Matthew Brost > > Reviewed-by: John Harrison > >=20 > > > --- > > > =A0 tests/i915/sysfs_preempt_timeout.c | 6 +++++- > > > =A0 1 file changed, 5 insertions(+), 1 deletion(-) > > >=20 > > > diff --git a/tests/i915/sysfs_preempt_timeout.c > > > b/tests/i915/sysfs_preempt_timeout.c > > > index d176ae72e..fe6b30236 100644 > > > --- a/tests/i915/sysfs_preempt_timeout.c > > > +++ b/tests/i915/sysfs_preempt_timeout.c > > > @@ -29,6 +29,7 @@ > > > =A0 #include > > > =A0 #include > > > +#include "igt.h" > > > =A0 #include "igt_params.h" > > > =A0 #include "drmtest.h" > > > =A0 #include "i915/gem.h" > > > @@ -41,7 +42,7 @@ > > > =A0 #include "sw_sync.h" > > > =A0 #define ATTR "preempt_timeout_ms" > > > -#define RESET_TIMEOUT 50 /* milliseconds, at least one jiffie for > > > kworker */ > > > +#define RESET_TIMEOUT 1000 /* milliseconds, at long enough for an > > > error capture */ > > > =A0 static bool __enable_hangcheck(int dir, bool state) > > > =A0 { > > > @@ -254,6 +255,9 @@ static void test_off(int i915, int engine) > > > =A0=A0=A0=A0=A0 gem_quiescent_gpu(i915); > > > =A0=A0=A0=A0=A0 igt_require(enable_hangcheck(i915, false)); > > > +=A0=A0=A0 /* Not a supported behavior for GuC enabled platforms */ > > > +=A0=A0=A0 igt_require(intel_gen(intel_get_drm_devid(i915)) < 12); > > > + > > > =A0=A0=A0=A0=A0 igt_assert(igt_sysfs_scanf(engine, "class", "%u", &cl= ass) =3D=3D 1); > > > =A0=A0=A0=A0=A0 igt_assert(igt_sysfs_scanf(engine, "instance", "%u", = &inst) =3D=3D 1); > >=20