From: Jeevan B <jeevan.b@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: petri.latvala@intel.com, jose.souza@intel.com, daniel@ffwll.ch,
Jeevan B <jeevan.b@intel.com>
Subject: [igt-dev] [PATCH i-g-t v2 2/3] tests/kms_psr2_sf: Make this a generic test and change testcase design
Date: Wed, 13 Oct 2021 22:40:50 +0530 [thread overview]
Message-ID: <20211013171051.26287-3-jeevan.b@intel.com> (raw)
In-Reply-To: <20211013171051.26287-1-jeevan.b@intel.com>
Make this a generic kms test and change testcase design so that it avoids
new subtest for each block position
Signed-off-by: Jeevan B <jeevan.b@intel.com>
---
tests/i915/kms_psr2_sf.c | 28 ++++++++++++++--------------
1 file changed, 14 insertions(+), 14 deletions(-)
diff --git a/tests/i915/kms_psr2_sf.c b/tests/i915/kms_psr2_sf.c
index 93347327..c83120c4 100644
--- a/tests/i915/kms_psr2_sf.c
+++ b/tests/i915/kms_psr2_sf.c
@@ -550,7 +550,7 @@ igt_main
igt_fixture {
int r;
- data.drm_fd = drm_open_driver_master(DRIVER_INTEL);
+ data.drm_fd = drm_open_driver_master(DRIVER_ANY);
data.debugfs_fd = igt_debugfs_dir(data.drm_fd);
kmstest_set_vt_graphics_mode();
@@ -582,9 +582,9 @@ igt_main
}
/* Verify primary plane selective fetch */
- for (i = 1; i <= MAX_DAMAGE_AREAS; i++) {
- igt_describe("Test that selective fetch works on primary plane");
- igt_subtest_f("primary-%s-sf-dmg-area-%d", op_str(data.op), i) {
+ igt_describe("Test that selective fetch works on primary plane");
+ igt_subtest_f("primary-%s-sf-dmg-area", op_str(data.op)) {
+ for (i = 1; i <= MAX_DAMAGE_AREAS; i++) {
data.damage_area_count = i;
data.test_plane_id = DRM_PLANE_TYPE_PRIMARY;
prepare(&data);
@@ -594,9 +594,9 @@ igt_main
}
/* Verify overlay plane selective fetch */
- for (i = 1; i <= MAX_DAMAGE_AREAS; i++) {
- igt_describe("Test that selective fetch works on overlay plane");
- igt_subtest_f("overlay-%s-sf-dmg-area-%d", op_str(data.op), i) {
+ igt_describe("Test that selective fetch works on overlay plane");
+ igt_subtest_f("overlay-%s-sf-dmg-area", op_str(data.op)) {
+ for (i = 1; i <= MAX_DAMAGE_AREAS; i++) {
data.damage_area_count = i;
data.test_plane_id = DRM_PLANE_TYPE_OVERLAY;
prepare(&data);
@@ -618,9 +618,9 @@ igt_main
/* Only for overlay plane */
data.op = PLANE_MOVE;
/* Verify overlay plane move selective fetch */
- for (i = POS_TOP_LEFT; i <= POS_BOTTOM_RIGHT ; i++) {
- igt_describe("Test that selective fetch works on moving overlay plane");
- igt_subtest_f("%s-sf-dmg-area-%d", op_str(data.op), i) {
+ igt_describe("Test that selective fetch works on moving overlay plane");
+ igt_subtest_f("%s-sf-dmg-area", op_str(data.op)) {
+ for (i = POS_TOP_LEFT; i <= POS_BOTTOM_RIGHT ; i++) {
data.pos = i;
data.test_plane_id = DRM_PLANE_TYPE_OVERLAY;
prepare(&data);
@@ -631,10 +631,10 @@ igt_main
/* Verify primary plane selective fetch with overplay plane blended */
data.op = OVERLAY_PRIM_UPDATE;
- for (i = 1; i <= MAX_DAMAGE_AREAS; i++) {
- igt_describe("Test that selective fetch works on primary plane "
- "with blended overlay plane");
- igt_subtest_f("%s-sf-dmg-area-%d", op_str(data.op), i) {
+ igt_describe("Test that selective fetch works on primary plane "
+ "with blended overlay plane");
+ igt_subtest_f("%s-sf-dmg-area", op_str(data.op)) {
+ for (i = 1; i <= MAX_DAMAGE_AREAS; i++) {
data.damage_area_count = i;
data.test_plane_id = DRM_PLANE_TYPE_PRIMARY;
prepare(&data);
--
2.19.1
next prev parent reply other threads:[~2021-10-13 17:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-13 17:10 [igt-dev] [PATCH i-g-t v2 0/3] Fix kms_psr2_sf test and add new test for FB_DAMAGE_CLIPS plane property Jeevan B
2021-10-13 17:10 ` [igt-dev] [PATCH i-g-t v2 1/3] lib/igt_aux: Rename igt_debug_manual_check and assert check if all is supplied Jeevan B
2021-11-08 14:43 ` Petri Latvala
2021-10-13 17:10 ` Jeevan B [this message]
2021-11-08 14:47 ` [igt-dev] [PATCH i-g-t v2 2/3] tests/kms_psr2_sf: Make this a generic test and change testcase design Petri Latvala
2021-10-13 17:10 ` [igt-dev] [PATCH i-g-t v2 3/3] tests/kms_atomic: Add a new test case for FB_DAMAGE_CLIPS plane property Jeevan B
2021-10-13 17:53 ` [igt-dev] ✓ Fi.CI.BAT: success for Fix kms_psr2_sf test and add new test for FB_DAMAGE_CLIPS plane property (rev2) Patchwork
2021-10-13 18:59 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211013171051.26287-3-jeevan.b@intel.com \
--to=jeevan.b@intel.com \
--cc=daniel@ffwll.ch \
--cc=igt-dev@lists.freedesktop.org \
--cc=jose.souza@intel.com \
--cc=petri.latvala@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox