From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by gabe.freedesktop.org (Postfix) with ESMTPS id C31D76E8AB for ; Tue, 19 Oct 2021 20:19:52 +0000 (UTC) From: Ville Syrjala Date: Tue, 19 Oct 2021 23:19:38 +0300 Message-Id: <20211019201940.31729-4-ville.syrjala@linux.intel.com> In-Reply-To: <20211019201940.31729-1-ville.syrjala@linux.intel.com> References: <20211019201940.31729-1-ville.syrjala@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Subject: [igt-dev] [PATCH i-g-t 3/5] tests/kms_tiled_display: Limit the difference in the timestamps to one scanline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: igt-dev@lists.freedesktop.org List-ID: From: Ville Syrjälä The 10 usec limit is rather abitrary. Let's choose another (perhaps a bit less) arbitrary value of single scanline. The timestamp could be off by some significant fraction of a scanline anyway since that's often the precision the hardware gives us for tracking the scanout position. Signed-off-by: Ville Syrjälä --- tests/kms_tiled_display.c | 27 ++++++++++++++++++++------- 1 file changed, 20 insertions(+), 7 deletions(-) diff --git a/tests/kms_tiled_display.c b/tests/kms_tiled_display.c index cb4762d7c6b1..7c8852b3496c 100644 --- a/tests/kms_tiled_display.c +++ b/tests/kms_tiled_display.c @@ -60,6 +60,7 @@ typedef struct { data_connector_t *conns; enum igt_commit_style commit; struct timeval first_ts; + int linetime_us; #ifdef HAVE_CHAMELIUM struct chamelium *chamelium; @@ -67,7 +68,6 @@ typedef struct { int port_count; struct chamelium_edid *edids[IGT_CUSTOM_EDID_COUNT]; #endif - } data_t; void basic_test(data_t *data, drmEventContext *drm_event, struct pollfd *pfd); @@ -207,6 +207,12 @@ static void test_cleanup(data_t *data) igt_display_commit2(&data->display, data->commit); memset(conns, 0, sizeof(data_connector_t) * data->num_h_tiles); } + +static int mode_linetime_us(const drmModeModeInfo *mode) +{ + return 1000 * mode->htotal / mode->clock; +} + static void setup_mode(data_t *data) { int count = 0, prev = 0, i = 0; @@ -263,6 +269,7 @@ static void setup_mode(data_t *data) } igt_require(found); igt_output_override_mode(output, mode); + data->linetime_us = mode_linetime_us(mode); } igt_display_commit_atomic(&data->display, DRM_MODE_ATOMIC_ALLOW_MODESET, NULL); @@ -330,6 +337,11 @@ static data_connector_t *conn_for_crtc(data_t *data, unsigned int crtc_id) return NULL; } +static float timeval_float(const struct timeval *tv) +{ + return tv->tv_sec + tv->tv_usec / 1000000.0f; +} + static void page_flip_handler(int fd, unsigned int seq, unsigned int tv_sec, unsigned int tv_usec, unsigned int crtc_id, void *_data) @@ -352,8 +364,8 @@ static void page_flip_handler(int fd, unsigned int seq, igt_assert_f(!conn->got_page_flip, "Got two page-flips for CRTC %u\n", crtc_id); - igt_debug("Page Flip Event received from CRTC:%d at %u:%u\n", crtc_id, - tv_sec, tv_usec); + igt_debug("Page Flip Event received from CRTC:%d at %.6f\n", + crtc_id, timeval_float(¤t_ts)); conn->got_page_flip = true; @@ -361,11 +373,12 @@ static void page_flip_handler(int fd, unsigned int seq, usec = diff.tv_sec * 1000000 + diff.tv_usec; /* - * For seamless tear-free display, the page flip event timestamps - * from all the tiles should not differ by more than 10us. + * We arbitrarily choose to say that the difference + * should be no more than a single scanline. */ - igt_fail_on_f(labs(usec) >= 10, "Delayed page flip event from CRTC:%d at %u:%u\n", - crtc_id, tv_sec, tv_usec); + igt_fail_on_f(labs(usec) > data->linetime_us, + "Mistimed page flip event from CRTC:%d at %.6f (diff %ld usec, max %d usec)\n", + crtc_id, timeval_float(¤t_ts), usec, data->linetime_us); } static bool got_all_page_flips(data_t *data) -- 2.32.0