From: "Zbigniew Kempczyński" <zbigniew.kempczynski@intel.com>
To: Marcin Bernatowicz <marcin.bernatowicz@linux.intel.com>
Cc: igt-dev@lists.freedesktop.org, lucas.demarchi@intel.com
Subject: Re: [igt-dev] [PATCH i-g-t] tests/device_reset: remove artificial timeout
Date: Wed, 10 Nov 2021 11:35:36 +0100 [thread overview]
Message-ID: <20211110103536.GA46415@zkempczy-mobl2> (raw)
In-Reply-To: <20211108134746.595247-1-marcin.bernatowicz@linux.intel.com>
On Mon, Nov 08, 2021 at 01:47:46PM +0000, Marcin Bernatowicz wrote:
> Do not use artificial timeout. Let the test fail or finish.
>
> Signed-off-by: Marcin Bernatowicz <marcin.bernatowicz@linux.intel.com>
> ---
> tests/device_reset.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/tests/device_reset.c b/tests/device_reset.c
> index 982ba5ef2a..e60d4c7fde 100644
> --- a/tests/device_reset.c
> +++ b/tests/device_reset.c
> @@ -301,8 +301,6 @@ igt_main
> set_device_filter(dev_path);
>
> igt_skip_on(!is_sysfs_reset_supported(dev.fds.dev));
> -
> - igt_set_timeout(60, "device reset tests timed out after 60s");
> }
>
> igt_describe("Unbinds driver from device, initiates reset"
> @@ -319,7 +317,6 @@ igt_main
> }
>
> igt_fixture {
> - igt_reset_timeout();
> cleanup_device_fds(&dev);
> }
> }
> --
> 2.30.2
>
Ok, we've discussed about this - if other vendors will complain
in the future we will revert and skip setting this timeout on i915.
So:
Acked-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
--
Zbigniew
prev parent reply other threads:[~2021-11-10 10:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-08 13:47 [igt-dev] [PATCH i-g-t] tests/device_reset: remove artificial timeout Marcin Bernatowicz
2021-11-08 14:59 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2021-11-08 16:27 ` [igt-dev] [PATCH i-g-t] " Janusz Krzysztofik
2021-11-08 17:30 ` Zbigniew Kempczyński
2021-11-08 17:15 ` [igt-dev] ✓ Fi.CI.IGT: success for " Patchwork
2021-11-10 10:35 ` Zbigniew Kempczyński [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211110103536.GA46415@zkempczy-mobl2 \
--to=zbigniew.kempczynski@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=lucas.demarchi@intel.com \
--cc=marcin.bernatowicz@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox