Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Jeevan B <jeevan.b@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Tejas Upadhyay <tejaskumarx.surendrakumar.upadhyay@intel.com>
Subject: [igt-dev] [PATCH i-g-t] tests/i915/kms_draw_crc : check tiling support
Date: Tue, 11 Jan 2022 16:24:31 +0530	[thread overview]
Message-ID: <20220111105431.9459-1-jeevan.b@intel.com> (raw)

From: Tejas Upadhyay <tejaskumarx.surendrakumar.upadhyay@intel.com>

We can check tiling support before executing test to avoid
failure and smoothly skipping expected failure.

Signed-off-by: Jeevan B <jeevan.b@intel.com>
Signed-off-by: Tejas Upadhyay <tejaskumarx.surendrakumar.upadhyay@intel.com>
---
 lib/intel_bufops.c        | 2 +-
 tests/i915/kms_draw_crc.c | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/lib/intel_bufops.c b/lib/intel_bufops.c
index f13063fa..4ba4271a 100644
--- a/lib/intel_bufops.c
+++ b/lib/intel_bufops.c
@@ -1176,7 +1176,7 @@ void intel_buf_write_aux_to_png(struct intel_buf *buf, const char *filename)
 #define DEFAULT_BUFOPS(__gen_start, __gen_end) \
 	.gen_start          = __gen_start, \
 	.gen_end            = __gen_end, \
-	.supported_hw_tiles = TILE_X | TILE_Y, \
+	.supported_hw_tiles = TILE_NONE | TILE_X | TILE_Y, \
 	.linear_to          = copy_linear_to_wc, \
 	.linear_to_x        = copy_linear_to_gtt, \
 	.linear_to_y        = copy_linear_to_gtt, \
diff --git a/tests/i915/kms_draw_crc.c b/tests/i915/kms_draw_crc.c
index 82c368e1..ff1520d1 100644
--- a/tests/i915/kms_draw_crc.c
+++ b/tests/i915/kms_draw_crc.c
@@ -182,6 +182,7 @@ static void draw_method_subtest(enum igt_draw_method method,
 	igt_skip_on(method == IGT_DRAW_MMAP_GTT &&
 		    !gem_has_mappable_ggtt(drm_fd));
 
+	igt_require(buf_ops_has_hw_fence(bops, modifier));
 	igt_require(format_is_supported(formats[format_index], modifier));
 
 	/* Use IGT_DRAW_MMAP_GTT/WC on an untiled buffer as the parameter for
-- 
2.17.1

             reply	other threads:[~2022-01-11 10:55 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-11 10:54 Jeevan B [this message]
2022-01-11 12:57 ` [igt-dev] ✗ GitLab.Pipeline: warning for tests/i915/kms_draw_crc : check tiling support Patchwork
2022-01-11 12:57 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
2022-01-11 17:56 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2022-01-11 21:39 ` [igt-dev] [PATCH i-g-t] " Juha-Pekka Heikkila

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220111105431.9459-1-jeevan.b@intel.com \
    --to=jeevan.b@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=tejaskumarx.surendrakumar.upadhyay@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox