From: Chuansheng Liu <chuansheng.liu@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: chuansheng.liu@intel.com
Subject: [igt-dev] [PATCH i-g-t] i915/gem_busy: Prevent context ban with right ctx id
Date: Mon, 24 Jan 2022 10:38:33 +0800 [thread overview]
Message-ID: <20220124023833.13535-1-chuansheng.liu@intel.com> (raw)
When running multiple hang tests, the code is intended to
disallow context ban at first, but it is always with fix
ctx id 0. It will cause below test failures when running
the test gem_busy:
--
tarting dynamic subtest: vcs0
(gem_busy:18571) ioctl_wrappers-CRITICAL: Test assertion failure
function gem_execbuf_wr, file ../lib/ioctl_wrappers.c:706:
(gem_busy:18571) ioctl_wrappers-CRITICAL: Failed assertion:
__gem_execbuf_wr(fd, execbuf) == 0
(gem_busy:18571) ioctl_wrappers-CRITICAL: error: -5 != 0
--
-5 (EIO) means the context is banned and can not be used for
execution.
This patch corrects the ctx id accordindly. Furthermore,
there are other code places with similar mistakes, will
try to send out the fixes further.
Signed-off-by: Chuansheng Liu <chuansheng.liu@intel.com>
---
tests/i915/gem_busy.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/i915/gem_busy.c b/tests/i915/gem_busy.c
index b4757736..b8a61084 100644
--- a/tests/i915/gem_busy.c
+++ b/tests/i915/gem_busy.c
@@ -517,7 +517,7 @@ igt_main
igt_hang_t hang;
igt_fixture {
- hang = igt_allow_hang(fd, 0, 0);
+ hang = igt_allow_hang(fd, ctx->id, 0);
}
test_each_engine("hang", fd, ctx, e) {
--
2.25.0.rc2
next reply other threads:[~2022-01-24 2:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-24 2:38 Chuansheng Liu [this message]
2022-01-24 3:31 ` [igt-dev] ✓ Fi.CI.BAT: success for i915/gem_busy: Prevent context ban with right ctx id Patchwork
2022-01-24 4:35 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2022-01-24 16:29 ` [igt-dev] [PATCH i-g-t] " Dixit, Ashutosh
2022-01-25 0:45 ` Liu, Chuansheng
2022-01-24 19:07 ` Dixit, Ashutosh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220124023833.13535-1-chuansheng.liu@intel.com \
--to=chuansheng.liu@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox