From: Jeevan B <jeevan.b@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: juha-pekka.heikkila@intel.com
Subject: [igt-dev] [PATCH i-g-t v3 12/15] tests/kms_frontbuffer_tracking: Add support for 4 tiling
Date: Wed, 16 Feb 2022 15:56:30 +0530 [thread overview]
Message-ID: <20220216102633.26949-13-jeevan.b@intel.com> (raw)
In-Reply-To: <20220216102633.26949-1-jeevan.b@intel.com>
From: Mika Kahola <mika.kahola@intel.com>
GEN12 uses 4 tiling instead of Y tiling. Let's add support for
tiling 4.
Signed-off-by: Mika Kahola <mika.kahola@intel.com>
Signed-off-by: Jeevan B <jeevan.b@intel.com>
---
tests/i915/kms_frontbuffer_tracking.c | 22 ++++++++++++++++++++--
1 file changed, 20 insertions(+), 2 deletions(-)
diff --git a/tests/i915/kms_frontbuffer_tracking.c b/tests/i915/kms_frontbuffer_tracking.c
index 532bfbb9..3f4c7e1b 100644
--- a/tests/i915/kms_frontbuffer_tracking.c
+++ b/tests/i915/kms_frontbuffer_tracking.c
@@ -136,6 +136,7 @@ struct test_mode {
TILING_LINEAR = 0,
TILING_X,
TILING_Y,
+ TILING_4,
TILING_COUNT,
TILING_DEFAULT = TILING_X,
} tiling;
@@ -462,6 +463,8 @@ static uint64_t tiling_to_modifier(enum tiling_type tiling)
return I915_FORMAT_MOD_X_TILED;
case TILING_Y:
return I915_FORMAT_MOD_Y_TILED;
+ case TILING_4:
+ return I915_FORMAT_MOD_4_TILED;
default:
igt_assert(false);
}
@@ -2232,6 +2235,8 @@ static bool tiling_is_valid(int feature_flags, enum tiling_type tiling)
case TILING_X:
case TILING_Y:
return true;
+ case TILING_4:
+ return AT_LEAST_GEN(devid, 12);
default:
igt_assert(false);
return false;
@@ -3208,6 +3213,8 @@ static int opt_handler(int option, int option_index, void *data)
opt.tiling = TILING_X;
else if (!strcmp(optarg, "y"))
opt.tiling = TILING_Y;
+ else if (!strcmp(optarg, "4"))
+ opt.tiling = TILING_4;
else if (!strcmp(optarg, "l")) {
opt.tiling = TILING_LINEAR;
} else {
@@ -3351,6 +3358,8 @@ static const char *tiling_str(enum tiling_type tiling)
return "x";
case TILING_Y:
return "y";
+ case TILING_4:
+ return "4";
default:
igt_assert(false);
}
@@ -3402,9 +3411,12 @@ struct option long_options[] = {
igt_main_args("", long_options, help_str, opt_handler, NULL)
{
struct test_mode t;
+ int devid;
- igt_fixture
+ igt_fixture {
setup_environment();
+ devid = intel_get_drm_devid(drm.fd);
+ }
for (t.feature = 0; t.feature < FEATURE_COUNT; t.feature++) {
if (!opt.show_hidden && t.feature == FEATURE_NONE)
@@ -3602,8 +3614,14 @@ igt_main_args("", long_options, help_str, opt_handler, NULL)
/* Tiling Y is only supported on GEN9+ */
if (t.tiling == TILING_Y) {
- int devid = intel_get_drm_devid(drm.fd);
igt_require(AT_LEAST_GEN(devid, 9));
+ igt_require(!intel_get_device_info(devid)->has_4tile);
+ }
+
+ /* Tiling 4 is only supported on GEN12+ */
+ if (t.tiling == TILING_4) {
+ igt_require(AT_LEAST_GEN(devid, 12));
+ igt_require(intel_get_device_info(devid)->has_4tile);
}
if (tiling_is_valid(t.feature, t.tiling))
--
2.17.1
next prev parent reply other threads:[~2022-02-16 10:27 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-16 10:26 [igt-dev] [PATCH i-g-t v3 00/15] DG2 platform definition and Tile 4 plane format support Jeevan B
2022-02-16 10:26 ` [igt-dev] [PATCH i-g-t v3 01/15] lib/intel_device_info: Add a flag to indicate tiling 4 support Jeevan B
2022-02-16 10:26 ` [igt-dev] [PATCH i-g-t v3 02/15] igt/lib: Add tile 4(F-tile) format support Jeevan B
2022-02-16 10:46 ` Petri Latvala
2022-02-16 10:56 ` B, Jeevan
2022-02-16 10:26 ` [igt-dev] [PATCH i-g-t v3 03/15] lib/igt_draw: Add pixel math for tile-4 Jeevan B
2022-02-16 10:26 ` [igt-dev] [PATCH i-g-t v3 04/15] igt/tests: Add support for Tile4(TileF) format to kms_draw_crc Jeevan B
2022-02-17 12:51 ` Lisovskiy, Stanislav
2022-02-18 8:15 ` B, Jeevan
2022-02-18 10:16 ` Lisovskiy, Stanislav
2022-02-18 10:23 ` B, Jeevan
2022-02-16 10:26 ` [igt-dev] [PATCH i-g-t v3 05/15] igt/tests: Add support for Tile4(TileF) format to kms_rotation_crc Jeevan B
2022-02-16 10:26 ` [igt-dev] [PATCH i-g-t v3 06/15] igt/tests: Add support for Tile4(TileF) format to tests/kms_plane_multiple Jeevan B
2022-02-16 10:26 ` [igt-dev] [PATCH i-g-t v3 07/15] igt/tests: Add support for Tile4(TileF) format to tests/kms_plane_lowres Jeevan B
2022-02-16 10:26 ` [igt-dev] [PATCH i-g-t v3 08/15] igt/tests: Add support for Tile4(TileF) format to tests/kms_big_fb Jeevan B
2022-02-16 10:26 ` [igt-dev] [PATCH i-g-t v3 09/15] igt/tests: Add support for Tile4(TileF) format to testdisplay Jeevan B
2022-02-16 10:26 ` [igt-dev] [PATCH i-g-t v3 10/15] lib/igt_draw: Use XY_FAST_COLOR_BLT on DG2 Jeevan B
2022-02-16 10:26 ` [igt-dev] [PATCH i-g-t v3 11/15] igt/tests: Add support for Tile4(TileF) format to tests/kms_addfb_basic Jeevan B
2022-02-16 10:26 ` Jeevan B [this message]
2022-02-16 10:26 ` [igt-dev] [PATCH i-g-t v3 13/15] tests/kms_draw_crc: Use 4 tiling when filling framebuffer Jeevan B
2022-02-16 10:26 ` [igt-dev] [PATCH i-g-t v3 14/15] tests/kms_plane_scaling: Adding Tile-4 support Jeevan B
2022-02-16 10:26 ` [igt-dev] [PATCH i-g-t v3 15/15] tests/kms_plane_scaling: Use tiling 4 if platform has support for it Jeevan B
2022-02-16 13:05 ` [igt-dev] ✗ Fi.CI.BAT: failure for DG2 platform definition and Tile 4 plane format support (rev3) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220216102633.26949-13-jeevan.b@intel.com \
--to=jeevan.b@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=juha-pekka.heikkila@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox