From: Jeevan B <jeevan.b@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: juha-pekka.heikkila@intel.com, petri.latvala@intel.com
Subject: [igt-dev] [PATCH i-g-t 05/10] igt/tests: Add support for Tile4(TileF) format to kms_draw_crc
Date: Fri, 25 Feb 2022 10:38:48 +0530 [thread overview]
Message-ID: <20220225050853.8349-6-jeevan.b@intel.com> (raw)
In-Reply-To: <20220225050853.8349-1-jeevan.b@intel.com>
From: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
kms_draw_crc would be the first sample test to support new
format.
v2: add check for tile-4 support
Signed-off-by: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
Signed-off-by: Jeevan B <jeevan.b@intel.com>
---
tests/i915/kms_draw_crc.c | 18 +++++++++++-------
1 file changed, 11 insertions(+), 7 deletions(-)
diff --git a/tests/i915/kms_draw_crc.c b/tests/i915/kms_draw_crc.c
index 82c368e1..33b7bdf4 100644
--- a/tests/i915/kms_draw_crc.c
+++ b/tests/i915/kms_draw_crc.c
@@ -41,25 +41,24 @@ drmModeConnectorPtr drm_connectors[MAX_CONNECTORS];
struct buf_ops *bops;
igt_pipe_crc_t *pipe_crc;
-#define N_FORMATS 3
-static const uint32_t formats[N_FORMATS] = {
+static const uint32_t formats[] = {
DRM_FORMAT_XRGB8888,
DRM_FORMAT_RGB565,
DRM_FORMAT_XRGB2101010,
};
-#define N_MODIFIER_METHODS 3
-static const uint64_t modifiers[N_MODIFIER_METHODS] = {
+static const uint64_t modifiers[] = {
DRM_FORMAT_MOD_LINEAR,
I915_FORMAT_MOD_X_TILED,
I915_FORMAT_MOD_Y_TILED,
+ I915_FORMAT_MOD_4_TILED,
};
struct base_crc {
bool set;
igt_crc_t crc;
};
-struct base_crc base_crcs[N_FORMATS];
+struct base_crc base_crcs[ARRAY_SIZE(formats)];
struct modeset_params ms;
@@ -178,6 +177,9 @@ static void draw_method_subtest(enum igt_draw_method method,
{
igt_crc_t crc;
+ igt_skip_on(modifier == I915_FORMAT_MOD_4_TILED &&
+ !HAS_4TILE(intel_get_drm_devid(drm_fd)));
+
igt_skip_on(method == IGT_DRAW_MMAP_WC && !gem_mmap__has_wc(drm_fd));
igt_skip_on(method == IGT_DRAW_MMAP_GTT &&
!gem_has_mappable_ggtt(drm_fd));
@@ -315,6 +317,8 @@ static const char *modifier_str(int modifier_index)
return "xtiled";
case I915_FORMAT_MOD_Y_TILED:
return "ytiled";
+ case I915_FORMAT_MOD_4_TILED:
+ return "4tiled";
default:
igt_assert(false);
}
@@ -328,9 +332,9 @@ igt_main
igt_fixture
setup_environment();
- for (format_idx = 0; format_idx < N_FORMATS; format_idx++) {
+ for (format_idx = 0; format_idx < ARRAY_SIZE(formats); format_idx++) {
for (method = 0; method < IGT_DRAW_METHOD_COUNT; method++) {
- for (modifier_idx = 0; modifier_idx < N_MODIFIER_METHODS; modifier_idx++) {
+ for (modifier_idx = 0; modifier_idx < ARRAY_SIZE(modifiers); modifier_idx++) {
igt_describe("This subtest verfies igt_draw library works "
"with different modifiers, DRM_FORMATS, DRAW_METHODS.");
igt_subtest_f("draw-method-%s-%s-%s",
--
2.17.1
next prev parent reply other threads:[~2022-02-25 5:09 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-25 5:08 [igt-dev] [PATCH i-g-t 00/10] Tile 4 plane format support Jeevan B
2022-02-25 5:08 ` [igt-dev] [PATCH i-g-t 01/10] lib/intel_device_info: Add a flag to indicate tiling 4 support Jeevan B
2022-02-25 5:08 ` [igt-dev] [PATCH i-g-t 02/10] include/drm-uapi: Introduce new Tile 4 format Jeevan B
2022-02-25 6:17 ` Zbigniew Kempczyński
2022-02-25 6:33 ` B, Jeevan
2022-02-25 5:08 ` [igt-dev] [PATCH i-g-t 03/10] igt/lib: Add tile 4(F-tile) format support Jeevan B
2022-02-25 8:37 ` Lisovskiy, Stanislav
2022-02-25 5:08 ` [igt-dev] [PATCH i-g-t 04/10] lib/igt_draw: Add pixel math for tile-4 Jeevan B
2022-02-25 8:39 ` Lisovskiy, Stanislav
2022-02-25 5:08 ` Jeevan B [this message]
2022-02-25 8:40 ` [igt-dev] [PATCH i-g-t 05/10] igt/tests: Add support for Tile4(TileF) format to kms_draw_crc Lisovskiy, Stanislav
2022-02-25 5:08 ` [igt-dev] [PATCH i-g-t 06/10] igt/tests: Add support for Tile4(TileF) format to tests/kms_plane_multiple Jeevan B
2022-02-25 8:41 ` Lisovskiy, Stanislav
2022-02-25 5:08 ` [igt-dev] [PATCH i-g-t 07/10] igt/tests: Add support for Tile4(TileF) format to tests/kms_plane_lowres Jeevan B
2022-02-25 8:42 ` Lisovskiy, Stanislav
2022-02-25 5:08 ` [igt-dev] [PATCH i-g-t 08/10] igt/tests: Add support for Tile4(TileF) format to tests/kms_big_fb Jeevan B
2022-02-25 8:42 ` Lisovskiy, Stanislav
2022-02-25 5:08 ` [igt-dev] [PATCH i-g-t 09/10] igt/tests: Add support for Tile4(TileF) format to testdisplay Jeevan B
2022-02-25 8:42 ` Lisovskiy, Stanislav
2022-02-25 5:08 ` [igt-dev] [PATCH i-g-t 10/10] igt/tests: Add support for Tile4(TileF) format to kms_rotation_crc Jeevan B
2022-02-25 8:43 ` Lisovskiy, Stanislav
2022-02-25 5:48 ` [igt-dev] ✓ Fi.CI.BAT: success for Tile 4 plane format support Patchwork
2022-02-25 22:44 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220225050853.8349-6-jeevan.b@intel.com \
--to=jeevan.b@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=juha-pekka.heikkila@intel.com \
--cc=petri.latvala@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox