Re: [igt-dev] [i-g-t 2/5] lib/igt_edid: Helper to read monitor range from EDID

["Navare, Manasi" <manasi.d.navare@intel.com>]

On Thu, Feb 24, 2022 at 10:46:45AM +0530, Bhanuprakash Modem wrote:
> Add a helper function to read Monitor's range capability
> from EDID.
> 
> Cc: Manasi Navare <manasi.d.navare@intel.com>
> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
> ---
>  lib/igt_edid.c | 24 ++++++++++++++++++++++++
>  lib/igt_edid.h |  2 ++
>  2 files changed, 26 insertions(+)
> 
> diff --git a/lib/igt_edid.c b/lib/igt_edid.c
> index df346c4c8c..bd677f49b8 100644
> --- a/lib/igt_edid.c
> +++ b/lib/igt_edid.c
> @@ -160,6 +160,30 @@ void detailed_timing_set_monitor_range_mode(struct detailed_timing *dt,
>  	       sizeof(monitor_range_padding));
>  }
>  
> +struct detailed_data_monitor_range
> +detailed_timing_get_monitor_range(const struct edid *edid)
> +{
> +	uint8_t i;
> +	struct detailed_data_monitor_range mr = {0, 0};
> +
> +	for (i = 0; i < DETAILED_TIMINGS_LEN; i++) {
> +		struct detailed_non_pixel *other_data;
> +		struct detailed_timing timings = edid->detailed_timings[i];
> +
> +		if (timings.pixel_clock[0] != 0 &&
> +		    timings.pixel_clock[1] != 0)
> +			continue;

What is this check checking? 

> +
> +		other_data = &timings.data.other_data;
> +		if (other_data->type != EDID_DETAIL_MONITOR_RANGE)
> +			continue;
> +
> +		return other_data->data.range;

Did you  mean to assign this range to mr here as that is what we return

Manasi

> +	}
> +
> +	return mr;
> +}
> +
>  /**
>   * detailed_timing_set_string: set a detailed timing to be a string
>   */
> diff --git a/lib/igt_edid.h b/lib/igt_edid.h
> index aac2f4a208..e412479d84 100644
> --- a/lib/igt_edid.h
> +++ b/lib/igt_edid.h
> @@ -381,6 +381,8 @@ void detailed_timing_set_mode(struct detailed_timing *dt, drmModeModeInfo *mode,
>  			      int width_mm, int height_mm);
>  void detailed_timing_set_monitor_range_mode(struct detailed_timing *dt,
>  					    drmModeModeInfo *mode);
> +struct detailed_data_monitor_range detailed_timing_get_monitor_range(
> +				const struct edid *edid);
>  void detailed_timing_set_string(struct detailed_timing *dt,
>  				enum detailed_non_pixel_type type,
>  				const char *str);
> -- 
> 2.35.0
>