Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Maxime Ripard <maxime@cerno.tech>
To: igt-dev@lists.freedesktop.org
Cc: Pekka Paalanen <ppaalanen@gmail.com>, Maxime Ripard <maxime@cerno.tech>
Subject: [igt-dev] [PATCH i-g-t 0/8] Writeback fixes and improvements
Date: Tue,  8 Mar 2022 16:21:33 +0100	[thread overview]
Message-ID: <20220308152141.2457841-1-maxime@cerno.tech> (raw)

Hi,

Here's a series addressing the writeback-check-output test not passing
on vc4. This is due to the fact that the writeback controller will force
the X component to 0, while we expect the output and input buffers to be
identical, and the input buffer has 0xff.

This series tackles this by adding some support to dump the faulty
frames in PNG and raw, which proved to be useful while debugging this
series. Then, we rework the hash function to ignore the X component of
our buffer and only hash the pixels themselves.

Finally, we change the input buffer X value to a garbage, different from
0 and 0xff, value to make sure the hardware properly ignores the
component and doesn't treat it as alpha.

Let me know what you think,
Maxime

Maxime Ripard (8):
  lib/igt_frame: Rename summary fd variable
  lib/igt_frame: Move frame dump logging to function
  lib/igt_frame: Move frame path creation to function
  lib/igt_frame: Add function to dump frames in RGB and raw
  tests/kms_writeback: Use endianness accessor to fill pixels
  tests/kms_writeback: Dump the frames if the don't match
  lib/igt_fb: Ignore the X component when computing CRC
  tests/kms_writeback: Use a garbage X value to create fill our test
    buffer

 lib/igt_core.h        |   9 +++
 lib/igt_fb.c          |  20 ++++--
 lib/igt_frame.c       | 137 ++++++++++++++++++++++++++++++++++++------
 lib/igt_frame.h       |   4 ++
 tests/kms_writeback.c |  40 +++++++++++-
 5 files changed, 185 insertions(+), 25 deletions(-)

-- 
2.35.1


             reply	other threads:[~2022-03-08 15:21 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-08 15:21 Maxime Ripard [this message]
2022-03-08 15:21 ` [igt-dev] [PATCH i-g-t 1/8] lib/igt_frame: Rename summary fd variable Maxime Ripard
2022-03-08 15:21 ` [igt-dev] [PATCH i-g-t 2/8] lib/igt_frame: Move frame dump logging to function Maxime Ripard
2022-03-08 15:21 ` [igt-dev] [PATCH i-g-t 3/8] lib/igt_frame: Move frame path creation " Maxime Ripard
2022-03-08 15:21 ` [igt-dev] [PATCH i-g-t 4/8] lib/igt_frame: Add function to dump frames in RGB and raw Maxime Ripard
2022-03-08 15:21 ` [igt-dev] [PATCH i-g-t 5/8] tests/kms_writeback: Use endianness accessor to fill pixels Maxime Ripard
2022-03-08 15:21 ` [igt-dev] [PATCH i-g-t 6/8] tests/kms_writeback: Dump the frames if the don't match Maxime Ripard
2022-03-08 15:21 ` [igt-dev] [PATCH i-g-t 7/8] lib/igt_fb: Ignore the X component when computing CRC Maxime Ripard
2022-03-08 15:21 ` [igt-dev] [PATCH i-g-t 8/8] tests/kms_writeback: Use a garbage X value to create fill our test buffer Maxime Ripard
2022-03-08 21:36 ` [igt-dev] ✓ Fi.CI.BAT: success for Writeback fixes and improvements Patchwork
2022-03-09  4:07 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220308152141.2457841-1-maxime@cerno.tech \
    --to=maxime@cerno.tech \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=ppaalanen@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox