Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: priyanka.dandamudi@intel.com
To: kamil.konieczny@linux.intel.com, igt-dev@lists.freedesktop.org,
	arjun.melkaveri@intel.com, priyanka.dandamudi@intel.com
Subject: [igt-dev] [PATCH i-g-t 1/2] i915/gem_wait: Add description for test and subtests
Date: Fri, 11 Mar 2022 12:04:52 +0530	[thread overview]
Message-ID: <20220311063453.180090-2-priyanka.dandamudi@intel.com> (raw)
In-Reply-To: <20220311063453.180090-1-priyanka.dandamudi@intel.com>

From: Priyanka Dandamudi <priyanka.dandamudi@intel.com>

Add description for test and all the subtests

v2: Rebase

v3: Modified descriptions

Signed-off-by: Apoorva Singh <apoorva1.singh@intel.com>
Signed-off-by: Priyanka Dandamudi <priyanka.dandamudi@intel.com>
Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com>
Cc: Arjun Melkaveri <arjun.melkaveri@intel.com>
---
 tests/i915/gem_wait.c | 14 ++++++++++++--
 1 file changed, 12 insertions(+), 2 deletions(-)

diff --git a/tests/i915/gem_wait.c b/tests/i915/gem_wait.c
index b17927b6..860a615c 100644
--- a/tests/i915/gem_wait.c
+++ b/tests/i915/gem_wait.c
@@ -32,6 +32,8 @@
 #include "igt.h"
 #include "igt_vgem.h"
 
+IGT_TEST_DESCRIPTION("Tests the GEM_WAIT ioctl");
+
 static int __gem_wait(int fd, struct drm_i915_gem_wait *w)
 {
 	int err;
@@ -185,9 +187,11 @@ igt_main
 		ctx = intel_ctx_create_all_physical(fd);
 	}
 
+	igt_describe("Verify that GEM_WAIT called with invalid flag will fail.");
 	igt_subtest("invalid-flags")
 		invalid_flags(fd);
 
+	igt_describe("Verify that GEM_WAIT called with invalid buffer object will fail.");
 	igt_subtest("invalid-buf")
 		invalid_buf(fd);
 
@@ -209,8 +213,11 @@ igt_main
 			igt_fork_signal_helper();
 		}
 
-		for (const typeof(*tests) *t = tests; t->name; t++)
+		for (const typeof(*tests) *t = tests; t->name; t++) {
+			igt_describe_f("Verify GEM_WAIT basic functionality in"
+				       " %s mode.", t->name);
 			test_all_engines(t->name, fd, ctx, t->flags);
+		}
 
 		igt_fixture {
 			igt_stop_signal_helper();
@@ -236,8 +243,11 @@ igt_main
 			igt_fork_signal_helper();
 		}
 
-		for (const typeof(*tests) *t = tests; t->name; t++)
+		for (const typeof(*tests) *t = tests; t->name; t++) {
+			igt_describe_f("Verify GEM_WAIT functionality in %s mode,"
+				       " when hang is allowed.", (t->name+5));
 			test_all_engines(t->name, fd, ctx, t->flags);
+		}
 
 		igt_fixture {
 			igt_stop_signal_helper();
-- 
2.25.1

  reply	other threads:[~2022-03-11  6:42 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-11  6:34 [igt-dev] [PATCH i-g-t 0/2] HAX add description to gem_wait priyanka.dandamudi
2022-03-11  6:34 ` priyanka.dandamudi [this message]
2022-03-29 15:31   ` [igt-dev] [PATCH i-g-t 1/2] i915/gem_wait: Add description for test and subtests Kamil Konieczny
2022-03-11  6:34 ` [igt-dev] [PATCH i-g-t 2/2] HAX: don't do full run priyanka.dandamudi
2022-03-11  7:17 ` [igt-dev] ✗ Fi.CI.BAT: failure for HAX add description to gem_wait Patchwork
  -- strict thread matches above, loose matches on Subject: below --
2022-04-04  7:00 [igt-dev] [PATCH i-g-t 0/2] " priyanka.dandamudi
2022-04-04  7:00 ` [igt-dev] [PATCH i-g-t 1/2] i915/gem_wait: Add description for test and subtests priyanka.dandamudi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220311063453.180090-2-priyanka.dandamudi@intel.com \
    --to=priyanka.dandamudi@intel.com \
    --cc=arjun.melkaveri@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=kamil.konieczny@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox